Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18485 closed enhancement (fixed)

don't warn about man_made=maypole looks like man_made=manhole

Reported by: Hanikatu Owned by: team
Priority: normal Milestone: 19.12
Component: Core validator Version:
Keywords: template_report man_made maypole Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. creat a node
  2. use as tag man_made=maypole
  3. check it

What is the expected result?

it is ok
(look here: https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dmaypole )

What happens instead?

The check shows that the value 'maypole' is unknown. Maybe 'manhole' is meant.

Please provide any additional information below. Attach a screenshot if possible.

check result

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-12-01 23:10:15 +0100 (Sun, 01 Dec 2019)
Build-Date:2019-12-02 02:30:57
Revision:15553
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15553 de) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 1119 MB / 1707 MB (279 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1440x900
Maximum Screen Size: 1440x900
VM arguments: [-Duser.home=%UserProfile%]
Dataset consistency test: No problems found

Plugins:
+ RoadSigns (35260)
+ buildings_tools (35248)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Power_Mapping_Utility_Simple&zip=1
+ D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Vorlagen\Strommastvorlage\Strommast_vorlage.zip
+ D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Vorlagen\Lichtvorlage\Licht.zip
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Kartenstiele\oberfläche\oberfläche.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/RecyclingMaterials&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Schools&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
- D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Kartenstiele\häuser\häuser.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip
- D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Kartenstiele\adresse\adresse.mapcss
+ D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Kartenstiele\Strommast\strommast.mapcss
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Kartenstiele\Richtung\ausrichtung.mapcss
+ D:\Benutzer\Desktop\altes\OpenStreetMap\JOSM\Kartenstiele\Licht\Licht.mapcss

Last errors/warnings:
- E: Id 'bavaria-80cm' is not unique - used by 'Bayern (80 cm)' and 'Bayern (80 cm)'!
- E: Fehler beim Laden des Bildes 'traffic_signs_presets/ES_tertiary.png'
- W:  Tertiary: Could not get presets icon traffic_signs_presets/ES_tertiary.png
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (1)

Clipboarder.2019.12.29.png (39.9 KB ) - added by Hanikatu 6 years ago.
check result

Download all attachments as: .zip

Change History (7)

by Hanikatu, 6 years ago

Attachment: Clipboarder.2019.12.29.png added

check result

comment:1 by Don-vip, 6 years ago

Description: modified (diff)

comment:2 by Don-vip, 6 years ago

Component: CoreInternal preset
Keywords: man_made maypole added
Summary: The check shows that the value 'maypole' is unknownAdd man_made=maypole
Type: defectenhancement

comment:3 by Klumbumbus, 6 years ago

In 15624/josm:

  • see #18485 - don't warn about man_made=maypole looks like man_made=manhole
  • don't warn about parking=yes|no without amenity=parking - while parking=yes|no is controversial as "yes" and "no" are no "parking types" (and not wiki documented too), the warning text is the wrong one anyway (see https://github.com/osm-fr/osmose-backend/issues/723)

comment:4 by Hanikatu, 6 years ago

Resolution: fixed
Status: newclosed

comment:5 by Don-vip, 6 years ago

Component: Internal presetCore validator
Milestone: 20.01
Summary: Add man_made=maypoledon't warn about man_made=maypole looks like man_made=manhole

comment:6 by Klumbumbus, 6 years ago

Milestone: 20.0119.12

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.