[PATCH] validation not possible right away

[skyper]

What steps will reproduce the problem?

1. start JOSM
2. create new layer
3. add a new way with two child nodes
4. add tag highway=road
5. open validator toggle dialog
6. try to run validator by clicking on the blue check mark button in toggle dialog

What is the expected result?

The button is enabled and validator test are run

What happens instead?

The button is disabled

Please provide any additional information below. Attach a screenshot if possible.

Adding an addition node after opening the toggle dialog will enable the button.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-12-21 15:53:55 +0100 (Sat, 21 Dec 2019)
Revision:15607
Build-Date:2019-12-22 02:30:55
URL:https://josm.openstreetmap.de/svn/trunk

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [TMS_BLOCK_v2] Resetting cache

[taylor.smock]

Minimal patch (calls updateEnabledState on show state change, specifically on showNotify)

[GerdP]

I think Shift+V should also work in that Situation, but it doesn't.

[GerdP]

I checked older snapshots. The last version where Shift+V worked when dialog was not yet open was r14832, r14842 doesn't work.

[GerdP]

In 15608/josm:

fix #18456: validation not possible right away (regression from r14835)
Enable validator when data layer exists, no matter if it is empty or not.

[skyper]

Replying to GerdP:

In 15608/josm:

fix #18456: validation not possible right away (regression from r14835)
Enable validator when data layer exists, no matter if it is empty or not.

Well, my example was not an empty layer, e.g. the test to check for empty data layers did/does not work/update, properly.

[GerdP]

Yes, the check is only performed when a data layer is created or removed. I don't want to add another listener which would check after each change. Normally there is data in a layer.