Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#18456 closed defect (fixed)

[PATCH] validation not possible right away

Reported by: skyper Owned by: team
Priority: normal Milestone: 19.12
Component: Core validator Version: latest
Keywords: button toggle dialog regression Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. start JOSM
  2. create new layer
  3. add a new way with two child nodes
  4. add tag highway=road
  5. open validator toggle dialog
  6. try to run validator by clicking on the blue check mark button in toggle dialog

What is the expected result?

The button is enabled and validator test are run

What happens instead?

The button is disabled

Please provide any additional information below. Attach a screenshot if possible.

Adding an addition node after opening the toggle dialog will enable the button.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-12-21 15:53:55 +0100 (Sat, 21 Dec 2019)
Revision:15607
Build-Date:2019-12-22 02:30:55
URL:https://josm.openstreetmap.de/svn/trunk

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [TMS_BLOCK_v2] Resetting cache

Attachments (1)

18456.patch (520 bytes) - added by taylor.smock 3 months ago.
Minimal patch (calls updateEnabledState on show state change, specifically on showNotify)

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 months ago by skyper

Description: modified (diff)

Changed 3 months ago by taylor.smock

Attachment: 18456.patch added

Minimal patch (calls updateEnabledState on show state change, specifically on showNotify)

comment:2 Changed 3 months ago by taylor.smock

Summary: validation not possible right away[PATCH] validation not possible right away

comment:3 Changed 3 months ago by GerdP

I think Shift+V should also work in that Situation, but it doesn't.

comment:4 Changed 3 months ago by GerdP

I checked older snapshots. The last version where Shift+V worked when dialog was not yet open was r14832, r14842 doesn't work.

comment:5 Changed 3 months ago by GerdP

Resolution: fixed
Status: newclosed

In 15608/josm:

fix #18456: validation not possible right away (regression from r14835)
Enable validator when data layer exists, no matter if it is empty or not.

comment:6 Changed 3 months ago by GerdP

Keywords: regression added
Milestone: 19.12

comment:7 in reply to:  5 Changed 3 months ago by skyper

Replying to GerdP:

In 15608/josm:

fix #18456: validation not possible right away (regression from r14835)
Enable validator when data layer exists, no matter if it is empty or not.

Well, my example was not an empty layer, e.g. the test to check for empty data layers did/does not work/update, properly.

comment:8 Changed 3 months ago by GerdP

Yes, the check is only performed when a data layer is created or removed. I don't want to add another listener which would check after each change. Normally there is data in a layer.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.