Modify

Opened 3 months ago

Closed 3 months ago

Last modified 4 days ago

#18365 closed defect (fixed)

Duplicated way nodes

Reported by: sharcrash@… Owned by: team
Priority: normal Milestone:
Component: Plugin contourmerge Version:
Keywords: template_report github Cc:

Description

What steps will reproduce the problem?

  1. Simply plotting a new way

What is the expected result?

Single node

What happens instead?

Duplicated node, JOSM renders a single node and it's only when the validation tools kicks in that i know it's a duplicated node.

Please provide any additional information below. Attach a screenshot if possible.

Here is a node in question https://www.openstreetmap.org/node/7016700611/
It's not even glued to any other way or area.
This has happened very often recently, i'd say every new contribution.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-01 23:59:01 +0100 (Fri, 01 Nov 2019)
Build-Date:2019-11-01 22:59:57
Revision:15492
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15492 en) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 1670 MB / 1820 MB (688 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1280x1024, \Display1 1280x1024
Maximum Screen Size: 1280x1024
Dataset consistency test: No problems found

Plugins:
+ SimplifyArea (34977)
+ areaselector (359)
+ austriaaddresshelper (57)
+ buildings_tools (35171)
+ continuosDownload (82)
+ contourmerge (v0.1.5)
+ ejml (35122)
+ geochat (35163)
+ imagery_offset_db (34908)
+ log4j (34908)
+ reltoolbox (35196)
+ reverter (35084)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (35230)
+ wikipedia (1.1.2)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
+ https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: No default layer selected, choosing first layer.
- E: java.lang.ArrayIndexOutOfBoundsException: 22
- E: java.lang.ArrayIndexOutOfBoundsException: 12

Attachments (2)

sample.osm (1.7 KB) - added by GerdP 3 months ago.
before merge
sample-after-merge.osm (1.5 KB) - added by GerdP 3 months ago.
after merge, left way contains the same node twice in a sequence

Download all attachments as: .zip

Change History (19)

comment:1 Changed 3 months ago by sharcrash@…

I rebooted JOSM with fresh downloaded data, unglued the node i linked and there are 4 nodes actually. So for sure i didn't even click twice the node inadvertently. Weirdly, the unglued new nodes do not have any historic data in OSM.

comment:2 Changed 3 months ago by GerdP

I don't exactly understand what the problem is.
I think it is possible that a defect mouse button creates two click events. I've replaced a few devices in my live because of that.
I am not sure but I think there is no code in JOSM to render duplicated nodes in a single way different.
Please try to describe what you expect to happen, maybe attach a file that shows the problem.

comment:3 Changed 3 months ago by anonymous

It's not about rendering. I've talked about the rendering because visually the node in JOSM is shown as a single node unconnected to anything else. If there would have been several clicks by myself or by the mouse on the same node, wouldn't that certainly had stopped the plotting of the new way? I don't recall i had to click again the end of it to continue plotting. I will pay attention now anyway.

comment:4 Changed 3 months ago by stoecker

Owner: changed from team to sharcrash@…
Status: newneedinfo

Please give a step by step description what you do. Your description is totally unclear. E.g. "Unglueing" can and will produce duplicate nodes even more than two depending on the situation.

comment:5 Changed 3 months ago by sharcrash@…

It's not that my description is unclear, it's rather it is so simple that there is nothing else to add. :) I was plotting a new way for an area, closed the way, not even on the duplicted node, added my tag. That's it! I've given you actually extra details on my previous comments (4 duplicated nodes, it's not glued to any other element, etc).

comment:6 Changed 3 months ago by stoecker

You can believe us, that your description is unclear. Please make a step-by-step guide or record a video or something alike so we know what you really did.

comment:7 Changed 3 months ago by GerdP

I've reverted https://www.openstreetmap.org/changeset/77678133 and now I undetstand what you mean.
The node appeared 4 times in the same way 750412325.
See version 1 of https://www.openstreetmap.org/way/750412325/history
This looks indeed like an error in JOSM.
So, please try to reproduce, maybe you press a special key while drawing or there is a plugin causing this?
Edit: Of course I've only reverted on my PC, I did not upload this.

Last edited 3 months ago by GerdP (previous) (diff)

comment:8 Changed 3 months ago by anonymous

So here is one with 8 duplicated nodes: https://www.openstreetmap.org/node/1315490033/
When the validation warned me of the diplication, i undid my edits until i reached that node. It was the first node of the way i have created... the next step was simply continuing the plotting around different elements. Once the way looped, i added the tag, used the merge contour plugin, cut the area on other places to create other features, once all finished, hit the upload to OSM then the validation tool warning kicked in. That's it.

comment:9 Changed 3 months ago by GerdP

Do you agree that the problem is caused by the merge contour plugin?

comment:10 Changed 3 months ago by anonymous

It's possible but I don't know. There seems no pattern though according that one node was not glued to anything else, and another is the first of a plotting. Also I just tried now to add new elements, i didn't get any warning. It was a small contribution though. Will try next time with a bigger one.

Changed 3 months ago by GerdP

Attachment: sample.osm added

before merge

Changed 3 months ago by GerdP

Attachment: sample-after-merge.osm added

after merge, left way contains the same node twice in a sequence

comment:11 Changed 3 months ago by GerdP

Component: CorePlugin contourmerge
Owner: changed from sharcrash@… to team
Status: needinfonew

I've installed the plugin and was able to reproduce the problem with the first attempt.

comment:13 Changed 3 months ago by sharcrash@…

Thanks for the confirmation of the problem's origin and for having taken the initiative to contact the plugin's editor.

comment:14 Changed 3 months ago by Don-vip

Keywords: github added
Resolution: othersoftware
Status: newclosed

Issue must be discussed on GitHub then.

comment:15 Changed 4 days ago by Gubaer

Resolution: othersoftwarefixed

Should be fixed in release v1.0.6 of the plugin Github Issue

comment:16 Changed 4 days ago by GerdP

I wonder why the plugin list still says that v0.1.5 is the current version.

comment:17 Changed 4 days ago by GerdP

Now it says v0.1.6 . Guess that is the right one?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.