Modify

Opened 2 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#18326 closed defect (fixed)

Interpret html text in overpass query assistant

Reported by: pyrog Owned by: Don-vip
Priority: minor Milestone: 19.11
Component: Core Version:
Keywords: template_report html overpass download Cc:

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

  1. Download from Overpass API
  2. Query assistant
  3. image="<a href="http://pic.free.in.th/id/8939add8bff0c608648d699f24507693" target="_blank"><img border="0" src="http://image.free.in.th/z/it/img_7116.jpg" alt="images by free.in.th"/></a>" global
  4. press download

What is the expected result?

Download the OSM object that have this "unusual" value…
…Or display an error message (the query was malformed in fact)

What happens instead?

The html image was interpreted and displayed:

html code interpreted in message box

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-06 00:36:45 +0100 (Wed, 06 Nov 2019)
Build-Date:2019-11-06 02:30:56
Revision:15519
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15519 fr) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G95)
Memory Usage: 1254 MB / 1820 MB (211 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69732928 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/31/583aa85f-4a297e61, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM (development version), -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-72a21903.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ CADTools (1008)
+ PicLayer (35104)
+ SeaMapEditor (34908)
+ apache-commons (35092)
+ apache-http (34908)
+ cadastre-fr (35194)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jts (35122)
+ opendata (35179)
+ reverter (35084)
+ tag2link (35149)
+ utilsplugin2 (35177)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ ${HOME}/Downloads/Rules_Pictures.validator.mapcss

Last errors/warnings:
- W: couldn't parse wizard input
- E: org.openstreetmap.josm.tools.UncheckedParseException
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<line 3: static error: Invalid regular expression: &quot;[File:&quot;>, Error Body=<<?xml version="1.0" encoding="UTF-8"?>
- E: Requête incorrecte - org.openstreetmap.josm.gui.widgets.HtmlPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: couldn't parse wizard input
- E: org.openstreetmap.josm.tools.UncheckedParseException
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<line 3: static error: Invalid regular expression: &quot;^[&quot;>, Error Body=<<?xml version="1.0" encoding="UTF-8"?>
- E: Requête incorrecte - org.openstreetmap.josm.gui.widgets.HtmlPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: couldn't parse wizard input
- E: org.openstreetmap.josm.tools.UncheckedParseException

Attachments (1)

Capture d’écran 2019-11-15 à 07.23.51.png (1.7 MB) - added by pyrog 2 months ago.
html code interpreted in message box

Download all attachments as: .zip

Change History (7)

Changed 2 months ago by pyrog

html code interpreted in message box

comment:1 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 7 weeks ago by Don-vip

Keywords: html overpass download added
Milestone: 19.11
Owner: changed from team to Don-vip
Priority: normalminor
Status: newassigned

comment:3 Changed 7 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15551/josm:

fix #18326 - escape HTML characters in overpass query wizard error dialog

comment:4 Changed 7 weeks ago by Klumbumbus

@Vincent: r15552, two more commits and the i18n update and we are ready for the release ;)

comment:5 Changed 7 weeks ago by Don-vip

Sorry I couldn't finish what I was working on and I'm on holidays now. Next time!

comment:6 Changed 7 weeks ago by Klumbumbus

Have a nice holiday!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.