Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18315 closed enhancement (wontfix)

validation error "alt_name without name"

Reported by: pangoSE Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

auto fix suggestion: convert to name=

Attachments (0)

Change History (5)

comment:1 by Klumbumbus, 6 years ago

Resolution: wontfix
Status: newclosed

The rule in combinations.mapcss is:

/* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 #16437 */
*[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!lock_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
  throwWarning: tr("alternative name without {0}", "{1.key}");
  group: tr("missing tag");
}

As the key is selected with the regexp _name$ this can find strange tags which need an other fix than simply converting it to name, so a autofix is to risky (and probably doesn't work anyway with the current mapcss implementation). Better let the user fix it manually.

comment:2 by pangoSE, 6 years ago

Could we break out alt_name from this rule and autofix just that and let the user look at the others manually?

comment:3 by Klumbumbus, 6 years ago

I don't think it is worth the trouble. Is it such a big problem or is there a special use case?

comment:4 by Klumbumbus, 6 years ago

And a fix from alt_name to name can still be the wrong fix. See e.g. https://www.openstreetmap.org/node/993960150 (correct would be old_name or disused:name or deletion, the shop tag is wrong too) or https://www.openstreetmap.org/node/781170257 (correct could be name or loc_name) or https://www.openstreetmap.org/node/4474749491 (correct could be name or description or deletion) or https://www.openstreetmap.org/node/3792570288 (correct would be to keep the three diffferent name tags and add name=Medizinisches Versorgungszentrum Freital),...

comment:5 by pangoSE, 6 years ago

I am convinced! Thanks for taking the time to bring up good arguments :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.