Modify

Opened 4 years ago

Closed 4 years ago

#18281 closed defect (duplicate)

Validator error message for tag opening_hours with SH

Reported by: bl2004@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report opening_hours Cc:

Description

What steps will reproduce the problem?

  1. An object located somewhere in France is selected with a tag opening_hours="value including SH variable" (i.e We 07:30-18:30; SH 07:30-18:30)
  2. Launch JOSM validator

What is the expected result? No error detected

What happens instead? The following message is displayed at the bottom of the screen (not in the valitation window):

An error occurred during evaluation of the value "We 07:30-18:30; SH 07:30-18:30". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition

Please provide any additional information below. Attach a screenshot if possible.

I recently submit a pull request which has been merged in order to add SH definition for France (fr.yaml). But the repository https://github.com/ypid/opening_hours.js specified by the error message is no longer kept up to date by his owner
The valid repository is https://github.com/opening-hours/opening_hours.js. It was in this latter that I did my PR.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-29 23:59:43 +0200 (Sun, 29 Sep 2019)
Build-Date:2019-09-29 22:01:37
Revision:15390
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15390 fr) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 815 MB / 1820 MB (461 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-1ce2a516, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=54561, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ ColorPlugin (1537115529)
+ DirectDownload (34977)
+ Mapillary (1.5.20)
+ apache-commons (35092)
+ apache-http (34908)
+ cadastre-fr (35167)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jogl (1.2.3)
+ jts (35122)
+ kendzi3d-resources (0.0.2)
+ log4j (34908)
+ measurement (35051)
+ reverter (35084)
+ tag2link (35149)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (35177)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1

Last errors/warnings:
- W: Not a single layer for the name 'Cadastre': []
- W: Not a single layer for the name 'Cadastre': []
- W: Not a single layer for the name 'Cadastre': []
- W: Not a single layer for the name 'Cadastre': []
- W: Not a single layer for the name 'Cadastre': []
- W: Not a single layer for the name 'Cadastre': []
- W: Not a single layer for the name 'Cadastre': []
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: javax.script.ScriptException: An error occurred during evaluation of the value "We 07:30-18:30; SH 07:30-18:30". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause : jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "We 07:30-18:30; SH 07:30-18:30". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition
- E: javax.script.ScriptException: An error occurred during evaluation of the value "We 07:30-18:30; SH 07:30-18:30". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition in <eval> at line number 46 at column number 4733. Cause : jdk.nashorn.internal.runtime.ECMAException: An error occurred during evaluation of the value "We 07:30-18:30; SH 07:30-18:30". Please submit a pull request: https://github.com/ypid/opening_hours.js. no SH definition

Attachments (0)

Change History (2)

comment:1 by Don-vip, 4 years ago

Component: CoreCore validator
Keywords: opening_hours added

comment:2 by Don-vip, 4 years ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #17936.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.