[RFC PATCH] BBox should have a method to determine functional equivalency

[taylor.smock]

When comparing bboxes from different sources (e.g., one from OSM and one from another service, e.g. MapWithAI), sometimes there is a very small difference (in this case, I've had differences of around 0.00001 degrees, which translates to roughly 1.5m). For the purposes of equals, this is OK, but if the bboxes are close enough to be functionally equal (for the purposes of the calling function), then equals doesn't work. contains doesn't always work for this, because sometimes the bboxes are slightly shifted.

So, I would like to add a function to the BBox class that looks something like this:

    public boolean bboxesAreFunctionallyEqual(BBox other, Double maxDifference) {
        return bboxesAreFunctionallyEqual(this, other, maxDifference);
    }

    public static boolean bboxesAreFunctionallyEqual(BBox bbox1, BBox bbox2, Double maxDifference) {
        if (maxDifference == null) {
            maxDifference = LatLon.MAX_SERVER_PRECISION;
        }
        return (bbox1 != null && bbox2 != null)
                && (Math.abs(bbox1.getBottomRightLat() - bbox2.getBottomRightLat()) < maxDifference
                        && Math.abs(bbox1.getBottomRightLon() - bbox2.getBottomRightLon()) < maxDifference
                        && Math.abs(bbox1.getTopLeftLat() - bbox2.getTopLeftLat()) < maxDifference
                        && Math.abs(bbox1.getTopLeftLon() - bbox2.getTopLeftLon()) < maxDifference);
    }

[Don-vip]

No objection, it's useful

[Don-vip]

In 15483/josm:

fix #18274 - BBox should have a method to determine functional equivalency (patch by taylor.smock)

[taylor.smock]

Something that I didn't notice is that error prone is complaining about AmbiguousMethodReference ( ​https://errorprone.info/bugpattern/AmbiguousMethodReference ).

The two functions are public boolean bboxesAreFunctionallyEqual(BBox other, Double maxDifference) and public static boolean bboxesAreFunctionallyEqual(BBox bbox1, BBox bbox2, Double maxDifference). Since the former calls the latter, I don't think it is a significant issue, but we can rename one method (maybe to bboxIsFunctionallyEqual(BBox other, Double maxDifference)).

[Don-vip]

In 15486/josm:

see #18274 - rename new method to make error_prone happy

[Don-vip]

In 15487/josm:

see #18274 - forgot to update unit test