#18254 closed enhancement (wontfix)
Add autofix for Wikidata validator check
| Reported by: | pyrog | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | template_report wikipedia wikidata | Cc: |
Description (last modified by )
What steps will reproduce the problem?
wikidata=https://www.wikidata.org/wiki/Q1169988
wikidata=https://www.wikidata.org/wiki/Q1957381
What is the expected result?
Get message "wikidata tag format is deprecated"
And have a button "repair"
What happens instead?
Get message "wikidata tag must be in Qnnnn format, where n is a digit"
No repair button
See https://taginfo.openstreetmap.org/search?q=www.wikidata.org#values
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-10-22 23:54:14 +0200 (Tue, 22 Oct 2019)
Build-Date:2019-10-23 01:30:56
Revision:15470
Relative:URL: ^/trunk
Identification: JOSM/1.5 (15470 fr) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G95)
Memory Usage: 378 MB / 1820 MB (175 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69732928 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/31/583aa85f-4a297e61, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM (development version), -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-72a21903.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found
Plugins:
+ CADTools (1008)
+ PicLayer (35104)
+ SeaMapEditor (34908)
+ apache-commons (35092)
+ apache-http (34908)
+ cadastre-fr (35194)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jts (35122)
+ opendata (35179)
+ reverter (35084)
+ tag2link (35149)
+ utilsplugin2 (35177)
Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1
Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
Last errors/warnings:
- W: No configuration settings found. Using hardcoded default values for all pools.
- E: Error header: Version mismatch: Provided 1, server had: 3 of Node 6716941318
- E: Conflits détectés - <html>L’envoi<strong>a échoué</strong> car le serveur possède une version plus récente<br>d’un nœud, chemin ou relation.<br>Le conflit a pour origine le <strong>nœud</strong> avec l’identifiant <strong>6 716 941 318</strong>,<br>le serveur possède la version 3, votre version est 1.<br><br>Cliquez sur <strong>Synchroniser le nœud 6 716 941 318</strong> pour synchroniser uniquement l’objet en conflit.<br>Cliquez sur <strong>Synchroniser tout le jeu de données</strong> pour synchroniser tout le jeu de données.<br>Cliquez sur <strong>Annuler</strong> pour annuler et continuer.<br></html>
- E: Handled by bug report queue: java.lang.NullPointerException
Attachments (0)
Change History (9)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
| Component: | Core → Core validator |
|---|
comment:3 by , 6 years ago
| Keywords: | wikipedia added |
|---|
comment:4 by , 6 years ago
| Keywords: | wikidata added |
|---|---|
| Summary: | Wikidata validator : "wikidata tag must be in Qnnnn format, where n is a digit" → Add autofix for Wikidata validator check |
| Type: | defect → enhancement |
comment:5 by , 6 years ago
| Description: | modified (diff) |
|---|
comment:6 by , 6 years ago
There are currently 19 (of 1,406,646) wikidata tags that are not in the Q### format. And none of these uses the format you describe in your ticket. So in my opinion it wouldn't be worth it to create an autofix, when this issue is currently non-existent.
In my experience, most people get the format of the wikidata tag correct most of the time and when they don't, it is most of the time some mistake that requires manual clean up.
Here's a little breakdown of the current ways people get the format wrong:
- 3× the same as the wikipedia tag on that object, just without language prefix
- 1× the full URL to a Commons file
- 5× the full URL to a Wikipedia article (one of the articles is about the person after whom the object is named)
- 1× the full URL to a News article about an anniversary of the place
- 1× the name of the object (a Wikipedia article exists for it in Arabic wikipedia)
- 3× the format that wikipedia=* expects (language:WikiArticleName), referencing a Wikipedia article
- 2× a year or range of years (possibly the date when the thing existed or was built, who knows)
- 1× the Q-number without the leading Q of the brand of the place
- then there is also "немецкая постройка" and "Auto Log", no idea what was meant by that
The only ones of these for which I could imagine an auto-fix is the full Wikipedia-URL and the format that the wikipedia tag uses. But as long as the numbers are so low, I think it wouldn't be worth it to create a validator rule that not only tells you that the format is wrong, but in which way it fails.
comment:7 by , 6 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
I agree. We don't need more complex rules for so less objects.
comment:8 by , 6 years ago
There are currently 19 (of 1,406,646) wikidata tags that are not in the Q### format. And none of these uses the format you describe in your ticket.
I cleaned hundreds of wikipedia/wikidata before you checked taginfo. That is why you don't get anything ;-)
comment:9 by , 6 years ago
If the number of false objects raises fast we can reconsider this ticket later.
Please always attach your status report.