Opened 6 years ago

Last modified 6 years ago

#18248 closed defect

raise maximum simplify-way.max-error — at Version 1

Reported by: Klumbumbus Owned by: Bjoeni
Priority: normal Milestone: 19.10
Component: Core Version: latest
Keywords: Cc:

Description (last modified by Don-vip)

r15419 added a maximum value for simplify-way.max-error which is 100.
I suggest to raise it to 10000, because e.g. to simplify the shapes for wiki:/Maps/Croatia?action=diff&version=15 (where one had 3338! nodes) I needed a simplify-way.max-error of 2000. I did it this way:

  • SimplifyWayAction.java

     
    133133        JPanel q = new JPanel(new GridBagLayout());
    134134        q.add(new JLabel(tr("Maximum error (meters): ")));
    135135        JSpinner n = new JSpinner(new SpinnerNumberModel(
    136                 s.getDouble(keyError, 3.0), 0.01, 100, 0.5));
     136                s.getDouble(keyError, 3.0), 0.01, 10000, 0.5));
    137137        q.add(n);
    138138        q.setBorder(BorderFactory.createEmptyBorder(14, 0, 10, 0));
    139139        p.add(q, GBC.eol());

and noticed no problems. Was there a reason for the 100 limit?
One open point with this change is when you type values >10000 it corrects them to 100 instead to 10000, I don't know where to fix that.

Another thing is if you add a larger simplify-way.max-error value directly in the preferences you get an exception. Not sure if that should be catched.

Change History (1)

comment:1 by Don-vip, 6 years ago

Cc: Bjoeni removed
Description: modified (diff)
Milestone: 19.10
Owner: changed from team to Bjoeni
Type: enhancementdefect

@Bjoeni can you please provide a patch for the different issues described here?

Note: See TracTickets for help on using tickets.