[Patch] raise maximum simplify-way.max-error

[Klumbumbus]

r15419 added a maximum value for simplify-way.max-error which is 100.
I suggest to raise it to 10000, because e.g. to simplify the shapes for wiki:/Maps/Croatia?action=diff&version=15 (where one had 3338! nodes) I needed a simplify-way.max-error of 2000. I did it this way:

SimplifyWayAction.java

@@ -133 +133 @@
         JPanel q = new JPanel(new GridBagLayout());
         q.add(new JLabel(tr("Maximum error (meters): ")));
         JSpinner n = new JSpinner(new SpinnerNumberModel(
-                s.getDouble(keyError, 3.0), 0.01, 100, 0.5));
+                s.getDouble(keyError, 3.0), 0.01, 10000, 0.5));
         q.add(n);
         q.setBorder(BorderFactory.createEmptyBorder(14, 0, 10, 0));
         p.add(q, GBC.eol());

and noticed no problems. Was there a reason for the 100 limit?
One open point with this change is when you type values >10000 it corrects them to 100 instead to 10000, I don't know where to fix that.

Another thing is if you add a larger simplify-way.max-error value directly in the preferences you get an exception. Not sure if that should be catched.

[Don-vip]

@Bjoeni can you please provide a patch for the different issues described here?

[Bjoeni]

I'll have a look, I don't remember why I did that half a year ago. But agreed it makes no sense at all.

[Bjoeni]

src/org/openstreetmap/josm/actions/SimplifyWayAction.java

@@ -133 +133 @@
         JPanel q = new JPanel(new GridBagLayout());
         q.add(new JLabel(tr("Maximum error (meters): ")));
         JSpinner n = new JSpinner(new SpinnerNumberModel(
-                s.getDouble(keyError, 3.0), 0.01, 100, 0.5));
+                s.getDouble(keyError, 3.0), 0.01, null, 0.5));
+        ((JSpinner.DefaultEditor) n.getEditor()).getTextField().setColumns(4);
         q.add(n);
         q.setBorder(BorderFactory.createEmptyBorder(14, 0, 10, 0));
         p.add(q, GBC.eol());

Let's just give the user the freedom he deserves ;)

I believe the reason it jumped back to 100 for you was that it just goes back to the last valid value entered.

[Bjoeni]

So yeah the reason I did that was probably because the width of the JSpinner is usually determined by its max value, so I just put 100, wanted to change it later and forgot about it.

[Bjoeni]

Updated the "patch" above, because I just noticed that SpinnerNumberModel takes null as an argument, so no need at all for Integer.MAX_VALUE.

[Don-vip]

In 15471/josm:

fix #18248 - raise maximum simplify-way.max-error (patch by Bjoeni)

[Don-vip]

Thanks!