#18232 closed enhancement (fixed)
remove Test.compareTo() and more
| Reported by: | GerdP | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 19.10 |
| Component: | Core validator | Version: | |
| Keywords: | sort | Cc: |
Description
Since r14973 there should be no code which calls this method.
I'd like to remove the method and the implements ... Comparable<Test> part but I don't know how to deprecate it first.
If I got that right this would also allow to remove all the rather ugly code to override method equals() and hashCode() in Test and the various classes which extend Test
Special case: the classes MapCSSTagChecker and MapCSSTagCheckerAndRule somehow "abuse" the equals() method.
Attachments (1)
Change History (9)
follow-up: 3 comment:1 by , 6 years ago
| Component: | Core → Core validator |
|---|---|
| Keywords: | sort added |
comment:2 by , 6 years ago
| Milestone: | → 19.10 |
|---|---|
| Type: | task → enhancement |
by , 6 years ago
| Attachment: | 18232.patch added |
|---|
comment:3 by , 6 years ago
Replying to Don-vip:
You can't really deprecate anything in this particular case. Go on and simply remove it. Just make sure to update all impacted plugins.
Not sure what to do with the plugins. I found pt_assistant and wikipedia which extend class Test, but both seem to work fine with a JOSM binary compiled with the attached patch.
Should I still modify plugin.main.version in gradle.properties and distribute new binaries for them?
comment:4 by , 6 years ago
Not sure. If it works, do nothing :) We'll see if someone report an error.
comment:6 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
You can't really deprecate anything in this particular case. Go on and simply remove it. Just make sure to update all impacted plugins.