Silence complaints about role sub_station/substation/line and stop complaining about missing empty role in route=power

[mkoniecz]

What steps will reproduce the problem?

1. encounter route=power relation
2. run validator

What is the expected result?

User gets actionable warnings.

What happens instead?

Role verification problem (3)
Role '<empty>' missing (1)
Role 'line' is not in templates (1)
Role 'substation' is not in templates (1)

Validator is not complaining about route=power relation itself (some people claim that it is a mistake, not sure whatever validator should take this view).

Validator is complaining about roles.

I think that validator should either
(1) complain that relation is used at all (I am not recommending this solution, I am unaware about situation)

or

(2) do not complain about its roles (silence complaints about standard roles in route=power relation)

What mapper is supposed to do with such warning? In my case I see nothing that I can actually improve, even after checking Wiki.

Please provide any additional information below. Attach a screenshot if possible.

​https://wiki.openstreetmap.org/wiki/Proposed_features/Power_routing_proposal/Tagging_similar_to_Transportation_routes

Triggered by ​https://www.openstreetmap.org/relation/9660021#map=15/50.0432/20.0272 during debugging a Nominatim bug ( ​https://github.com/openstreetmap/Nominatim/issues/1520 )

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-10-08 23:08:20 +0200 (Tue, 08 Oct 2019)
Build-Date:2019-10-08 21:10:57
Revision:15445
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15445 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 428 MB / 869 MB (264 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ imagery_offset_db (34908)
+ jts (35122)
+ log4j (34908)
+ measurement (35051)
+ reverter (35084)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss to tag checker
- W: java.nio.file.NoSuchFileException: ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

[Klumbumbus]

In 15453/josm:

fix #18219 - fix accepted power route roles

[Don-vip]

In 15455/josm:

see #18219, see #18216 - update unit tests