Exception occurs when upload changes

[anonymous]

What steps will reproduce the problem?

1. Opened .osm file
2. Changed some tags
3. Tried to upload

What is the expected result?

Upload summary dialog comes

What happens instead?

Exception occurs

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-29 23:59:43 +0200 (Sun, 29 Sep 2019)
Build-Date:2019-09-29 22:01:37
Revision:15390
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15390 en) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 1809 (17763)
Memory Usage: 1152 MB / 1820 MB (377 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (34908)
+ FixAddresses (34977)
+ Mapillary (1.5.19)
+ OpenStreetCam (256)
+ OpeningHoursEditor (34977)
+ apache-commons (35092)
+ apache-http (34908)
+ buildings_tools (34982)
+ imagery_offset_db (34908)
+ jna (34908)
+ reverter (35084)
+ scripting (30796)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (35098)

Map paint styles:
- http://kolesar.turistautak.hu/osm/styles/measurements.mapcss
- http://kolesar.turistautak.hu/osm/styles/signal-size.mapcss
- http://kolesar.turistautak.hu/osm/styles/cellid.mapcss

Last errors/warnings:
- W: Invalid plugin main version '0.1.0' in plugin microdata_scraping
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Parameter 'p4' must not be null


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (17) of main
java.lang.IllegalArgumentException: Parameter 'p4' must not be null
	at org.openstreetmap.josm.tools.CheckParameterUtil.ensureParameterNotNull(CheckParameterUtil.java:69)
	at org.openstreetmap.josm.tools.CheckParameterUtil.ensure(CheckParameterUtil.java:52)
	at org.openstreetmap.josm.tools.Geometry.getSegmentSegmentIntersection(Geometry.java:299)
	at org.openstreetmap.josm.tools.Geometry.addIntersections(Geometry.java:166)
	at org.openstreetmap.josm.data.validation.tests.UnconnectedWays$MyWaySegment.barrierBetween(UnconnectedWays.java:548)
	at org.openstreetmap.josm.data.validation.tests.UnconnectedWays$MyWaySegment.access$000(UnconnectedWays.java:411)
	at org.openstreetmap.josm.data.validation.tests.UnconnectedWays.getHighwayEndNodesNearOtherHighway(UnconnectedWays.java:257)
	at org.openstreetmap.josm.data.validation.tests.UnconnectedWays.endTest(UnconnectedWays.java:376)
	at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:67)
	at org.openstreetmap.josm.actions.UploadAction.checkPreUploadConditions(UploadAction.java:218)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:242)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:303)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[anonymous]

osm file causing upload problem

[GerdP]

In 15407/josm:

fix #18198: Make sure that found way is usable, regression from r15344

[GerdP]

The check for barriers between unconnected highways did not consider the case that the barrier way has incomplete nodes.
If I got that right this is a rather special case, it seems the data was filtered by osmconvert before using it in JOSM.

[GerdP]

I wonder if JOSM could warn when a loaded dataset contains incomplete ways. If the mapper uses a tool like omsconvert to extract an area and doesn't use the options to keep ways complete it is likely that modifications are causing trouble when they are uploaded. Another potential problem here is that the file contains a bounds statement but obviously doesn't contain all data within these bounds. See also #18122.