#18116 closed enhancement (fixed)
DownloadAlong should not downloaded data in already downloaded areas
| Reported by: | stoecker | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 19.09 |
| Component: | Core | Version: | |
| Keywords: | download along | Cc: | Don-vip |
Description
If download along a GPX fails or aborts it has to be restarted from scratch. That wastes a lot of network bandwidth.
A proper solution would be to download only areas which are not in the current downloaded data set. That saves network bandwidth and also allows a simple recovery after an abort.
Attachments (1)
Change History (15)
comment:1 by , 5 years ago
| Type: | defect → enhancement |
|---|
comment:2 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 5 years ago
| Milestone: | → 19.09 |
|---|
comment:5 by , 5 years ago
I can see at least one situation where this causes a problem: we download a big area with overpass (which brings us only partial data); then try to download the complete data around a way.
With this current modification it won't download anything.
Try to download along the way in the attached example to see this problem.
by , 5 years ago
| Attachment: | example.osm added |
|---|
comment:6 by , 5 years ago
I thought about a checkbox to enable/disable the feature, but was too lazy :-) Patches welcome.
follow-up: 8 comment:7 by , 5 years ago
OTOH a proper solution would be, that partial data downloads don't set download bounds.
comment:8 by , 5 years ago
Replying to stoecker:
OTOH a proper solution would be, that partial data downloads don't set download bounds.
Yes, many tests in validator depend on the information and fail here.
Maybe we can separate "fully downloaded areas" from others?
comment:9 by , 5 years ago
I think simply setting no bounds would be fine. If no other data is downloaded you don't get a "fog of war". If other data is downloaded the fog will cover the outside data. That would be identical to data overlapping the download area.
comment:10 by , 5 years ago
Yes, might work. I have to look at the code again. We have different methods, some look for "node inside downloaded area", others for "not outside".
comment:11 by , 5 years ago
I found no obvious way to distinguish a partial download from a full download when overpass api is used.
Would you want to consider all overpass downloads as partial?
We might want to detect those downloads as full where method OverpassDownloadSourcePanel.checkDownload() "repaired" an empty query.
comment:12 by , 5 years ago
Please continue discussion in #18122. I'd say better safe than sorry, so consider all Overpass as partial except for these were we are sure they are full :-)
In 15340/josm: