Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#18116 closed enhancement (fixed)

DownloadAlong should not downloaded data in already downloaded areas

Reported by: stoecker Owned by: team
Priority: normal Milestone: 19.09
Component: Core Version:
Keywords: download along Cc: Don-vip

Description

If download along a GPX fails or aborts it has to be restarted from scratch. That wastes a lot of network bandwidth.

A proper solution would be to download only areas which are not in the current downloaded data set. That saves network bandwidth and also allows a simple recovery after an abort.

Attachments (1)

example.osm (1.6 KB) - added by naoliv 5 weeks ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 5 weeks ago by stoecker

Type: defectenhancement

comment:2 Changed 5 weeks ago by stoecker

Resolution: fixed
Status: newclosed

In 15340/josm:

fix #18116 - don't 'download along' already downloaded areas

comment:3 Changed 5 weeks ago by stoecker

Milestone: 19.09

comment:4 Changed 5 weeks ago by Don-vip

Keywords: download along added

great :)

comment:5 Changed 5 weeks ago by naoliv

I can see at least one situation where this causes a problem: we download a big area with overpass (which brings us only partial data); then try to download the complete data around a way.
With this current modification it won't download anything.

Try to download along the way in the attached example to see this problem.

Changed 5 weeks ago by naoliv

Attachment: example.osm added

comment:6 Changed 5 weeks ago by stoecker

I thought about a checkbox to enable/disable the feature, but was too lazy :-) Patches welcome.

comment:7 Changed 5 weeks ago by stoecker

OTOH a proper solution would be, that partial data downloads don't set download bounds.

comment:8 in reply to:  7 Changed 5 weeks ago by GerdP

Replying to stoecker:

OTOH a proper solution would be, that partial data downloads don't set download bounds.

Yes, many tests in validator depend on the information and fail here.
Maybe we can separate "fully downloaded areas" from others?

comment:9 Changed 5 weeks ago by stoecker

I think simply setting no bounds would be fine. If no other data is downloaded you don't get a "fog of war". If other data is downloaded the fog will cover the outside data. That would be identical to data overlapping the download area.

comment:10 Changed 5 weeks ago by GerdP

Yes, might work. I have to look at the code again. We have different methods, some look for "node inside downloaded area", others for "not outside".

comment:11 Changed 5 weeks ago by GerdP

I found no obvious way to distinguish a partial download from a full download when overpass api is used.
Would you want to consider all overpass downloads as partial?
We might want to detect those downloads as full where method OverpassDownloadSourcePanel.checkDownload() "repaired" an empty query.

Last edited 5 weeks ago by GerdP (previous) (diff)

comment:12 Changed 5 weeks ago by stoecker

Please continue discussion in #18122. I'd say better safe than sorry, so consider all Overpass as partial except for these were we are sure they are full :-)

Last edited 5 weeks ago by stoecker (previous) (diff)

comment:13 Changed 5 weeks ago by Don-vip

In 15349/josm:

see #18116 - checkstyle

comment:14 Changed 5 weeks ago by Don-vip

In 15350/josm:

see #18116 - findbugs - RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.