Modify

Opened 6 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#18091 closed defect (fixed)

shortcut of "Go to OSM wiki for tag help" not reassignable

Reported by: Klumbumbus Owned by: Don-vip
Priority: minor Milestone: 20.01
Component: Core shortcuts Version:
Keywords: template_report help Cc:

Description

What steps will reproduce the problem?

  1. right click on a tag in the tag/membership dialog
  2. see how "Go to OSM wiki for tag help" has F1 as shortcut
  3. "Go to OSM wiki for tag help" is not reassignable in the shortcut preferences

Please provide any additional information below. Attach a screenshot if possible.

Background:
I reassigned copy to F1, paste tags to F2 and Help to F4. If focus is the tags/membership dialog copying of objects with F1 does not work as "Go to OSM wiki for tag help" kicks in which is still on F1.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-27 20:34:29 +0200 (Tue, 27 Aug 2019)
Build-Date:2019-08-28 01:30:52
Revision:15324
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15324 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1903 (18362)
Memory Usage: 694 MB / 1820 MB (316 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=64404, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (35041)
+ HouseNumberTaggingTool (34977)
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ SimplifyArea (34977)
+ apache-commons (34908)
+ apache-http (34908)
+ buildings_tools (34982)
+ editgpx (34908)
+ geojson (124)
+ imagery-xml-bounds (35100)
+ imagery_offset_db (34908)
+ jaxb (35014)
+ jna (34908)
+ jogl (1.2.3)
+ log4j (34908)
+ measurement (35051)
+ osm-obj-info (51)
+ photo_geotagging (34908)
+ photoadjust (34977)
+ reltoolbox (34977)
+ reverter (35084)
+ rex (53)
+ tag2link (35070)
+ tageditor (34977)
+ tagging-preset-tester (34908)
+ terracer (34977)
+ turnlanes-tagging (281)
+ turnrestrictions (34977)
+ undelete (34977)
+ utilsplugin2 (35098)
+ wikipedia (v1.1.1)

Attachments (0)

Change History (4)

comment:1 Changed 6 months ago by Don-vip

Keywords: help added

Indeed:

public class HelpAction extends AbstractAction {
...
    public HelpAction(JTable tagTable, IntFunction<String> tagKeySupplier, IntFunction<Map<String, Integer>> tagValuesSupplier,
            JTable membershipTable, IntFunction<IRelation<?>> memberValueSupplier) {
...
        putValue(NAME, tr("Go to OSM wiki for tag help"));
...
        putValue(ACCELERATOR_KEY, getKeyStroke());
    }

    /**
     * Returns the keystroke launching this action (F1).
     * @return the keystroke launching this action
     */
    public KeyStroke getKeyStroke() {
        return KeyStroke.getKeyStroke(KeyEvent.VK_F1, 0);
    }
...
public class PropertiesDialog extends ToggleDialog
...
    /**
     * Assigns all needed keys like Enter and Spacebar to most important actions.
     */
    private void setupKeyboardShortcuts() {
...
        // F1 button = custom help action
        getInputMap(JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT).put(
                helpAction.getKeyStroke(), "onHelp");

comment:2 Changed 6 weeks ago by Don-vip

Milestone: 20.01
Owner: changed from team to Don-vip
Priority: normalminor
Status: newassigned

comment:3 Changed 6 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15644/josm:

fix #18091 - reuse Help shortcut inside tag/membership dialog

comment:4 Changed 6 weeks ago by Klumbumbus

Thanks. That simplifies my workflow.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.