Modify

Opened 3 months ago

Closed 8 weeks ago

#18088 closed defect (fixed)

Splitting a restriction relation with multiple via-ways breaks restriction relation

Reported by: osm@… Owned by: Don-vip
Priority: normal Milestone: 19.09
Component: Core Version:
Keywords: relations restriction via split Cc:

Description

If one attempts to split the from or to way in a restriction(-like) relation and the there are multiple consecutive via-ways, JOSM does not split up the restriction relation correctly.

The culprit is at SplitWayCommand line 425

JOSM assumes there can only be one relation member with the role via. But according to the wiki, it can be one or several (consecutive) relation members that are ways.

(I checked both iD and Vespucci code, they both check for a list of relation members with a via* role)

Attachments (0)

Change History (7)

comment:1 Changed 3 months ago by Don-vip

Owner: changed from team to osm@…
Status: newneedinfo

Can you please attach your status report?

comment:2 Changed 3 months ago by osm@…

Sure, here it is

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-08-26 08:55:27 +0200 (Mon, 26 Aug 2019)
Build-Date:2019-08-26 06:57:10
Revision:15322
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15322 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 1809 (17763)
Memory Usage: 936 MB / 1820 MB (454 MB allocated, but free)
Java version: 1.8.0_211-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 2560x1440
Maximum Screen Size: 2560x1440

Plugins:
+ FastDraw (34977)
+ Mapillary (1.5.18)
+ OpenStreetCam (251)
+ ShapeTools (1240)
+ apache-commons (34908)
+ apache-http (34908)
+ buildings_tools (34982)
+ ejml (35049)
+ geotools (34908)
+ jaxb (35014)
+ jna (34908)
+ jts (35064)
+ measurement (35051)
+ merge-overlap (35072)
+ opendata (35102)
+ terracer (34977)
+ utilsplugin2 (35098)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
Last edited 8 weeks ago by Don-vip (previous) (diff)

comment:3 Changed 3 months ago by Don-vip

Owner: changed from osm@… to team
Status: needinfonew

comment:4 Changed 3 months ago by osm@…

I had the same bug in StreetComplete and fixed it now.
Since the implementation of the split way algorithm in the app is not by chance quite similar to the implementation in JOSM, maybe this can be of help:

SplitSingleWayUpload.kt#L329-L339

comment:5 Changed 8 weeks ago by Don-vip

Keywords: via split added

comment:6 Changed 8 weeks ago by Don-vip

Milestone: 19.09
Owner: changed from team to Don-vip
Status: newassigned

comment:7 Changed 8 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15362/josm:

fix #18088 - see #18006 - Allow splitting a connectivity/restriction relation with multiple via-ways

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.