Modify

Opened 5 years ago

Closed 4 years ago

#17984 closed enhancement (fixed)

add line_attachment in power supports presets

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 19.10
Component: Internal preset Version:
Keywords: line_attachment, power, telecom Cc:

Description (last modified by francois.lacombe)

Dear maintainers,

The key line_attachment has been very recently reviewed on the wiki and received an approval vote.
https://wiki.openstreetmap.org/wiki/Key:line_attachment

The post-vote cleanup is in progress and documentation is currently under completion.
It may be great to update JOSM presets as follow :

  • Add the key with its four values on power supports presets power=tower, power=pole, power=insulator, power=portal and power=terminal
  • Remove anchor and suspension as possible values for tower:type key in any context.
  • Warn about the use of tower:type=anchor and encourage the replacement with line_attachment=anchor
  • Warn about the use of tower:type=suspension and encourage the replacement with line_attachment=suspension
  • Warn about the use of line_attachment on any other feature than a node.

Feel free to ask for any unclear point, all the best

François

Attachments (0)

Change History (21)

comment:1 by francois.lacombe, 5 years ago

Description: modified (diff)

comment:2 by Klumbumbus, 5 years ago

Milestone: 19.08

in reply to:  description ; comment:3 by Klumbumbus, 5 years ago

Replying to francois.lacombe:

key with its four values

suspension, anchor, pin and ?

comment:4 by Klumbumbus, 5 years ago

Summary: Intorduction of line_attachment in presetsadd line_attachment in power supports presets

in reply to:  3 comment:5 by francois.lacombe, 5 years ago

Replying to Klumbumbus:

suspension, anchor, pin and ?

pulley, currently not visible in the db
https://wiki.openstreetmap.org/wiki/Tag:line_attachment%3Dpulley

All the best

comment:7 by francois.lacombe, 5 years ago

Because the value doesn't appear in the db yet and the table is got from taginfo.
Look in the wikicode : {{Taglist|tags=line_attachment=suspension,anchor,pin,pulley|with_count=true}}, pulley is actually member of the list but it will only appear once a feature will be tagged with, according to taginfo

comment:8 by Klumbumbus, 5 years ago

Ah, OK I wasn't aware of the Taglist template.

in reply to:  description comment:9 by Klumbumbus, 5 years ago

Replying to francois.lacombe:

  • Warn about the use of line_attachment on any other feature than a node.

But line_attachment can be used on power=insulator or power=portal mapped as way!?

comment:10 by Klumbumbus, 5 years ago

Milestone: 19.0819.09

comment:11 by francois.lacombe, 5 years ago

I agree wiki is not clear on that particular case.
Nevertheless, see how it goes when a portal is described as a way : https://wiki.openstreetmap.org/wiki/Tag:power%3Dportal
The line(s) is/are connected to it with power=insulator node and then line_attachment should go on the insulator, not on the portal.

I guess it's the same for insulator, the attachment is still punctual.
I'll try to give a better description to it shortly.

comment:12 by Klumbumbus, 5 years ago

Milestone: 19.0919.10

comment:13 by francois.lacombe, 5 years ago

Hi Klumbumbus
I think you can go on with his one, on nodes only.
This is because it has to be used on connection between lines and their supports. Is it ok for you?

in reply to:  13 comment:14 by anonymous, 5 years ago

Replying to francois.lacombe:

Is it ok for you?

Yes. I do it after the next release. Now it was too short before the release.

comment:15 by francois.lacombe, 5 years ago

Great, thank you
No problem regarding time required to achieve it.

comment:16 by Klumbumbus, 5 years ago

Resolution: fixed
Status: newclosed

In 15454/josm:

fix #17984 - deprecate tower:type=anchor|suspension in favor of line_attachment=anchor|suspension

in reply to:  description comment:17 by Klumbumbus, 5 years ago

Replying to francois.lacombe:

  • Add the key with its four values on power supports presets power=tower, power=pole, power=insulator, power=portal and power=terminal
  • Remove anchor and suspension as possible values for tower:type key in any context.
  • Warn about the use of tower:type=anchor and encourage the replacement with line_attachment=anchor
  • Warn about the use of tower:type=suspension and encourage the replacement with line_attachment=suspension
  • Warn about the use of line_attachment on any other feature than a node.

Thanks for this detailed list of what actually needs to be done.

comment:18 by mdk, 5 years ago

Even if it is not explicitly written for the key pole:type, this key is used similar to tower:type (together with power=tower). Especially

  • pole:type=anchor (used 1764 times)
  • pole:type=suspension (used 1 883 times)

Perhaps the warning to use line_attachment instead should also be used here.

Other values of tower:type could also be found for pole:type like

  • pole:type=termination (used 1 260 times)
  • pole:type=branch (used 1 327 times)

The values transposing and crossing would make sense, but are not really in use.

Last edited 5 years ago by mdk (previous) (diff)

comment:19 by Klumbumbus, 5 years ago

Resolution: fixed
Status: closedreopened

comment:20 by francois.lacombe, 5 years ago

Hi,

Indeed, line_attachment proposal is also valid for pole:type (and any other key :type regarding line support)
I second mdk point to extend warnings about pole:type too.

Regarding the second part, about transposing and crossing. There is another draft proposal that takes care of those values
https://wiki.openstreetmap.org/wiki/Proposed_features/Lines_management
line_management will end the cleaning of tower:type and pole:type from those particular values.
So i recommend to don't edit anything regarding them for now.

All the best

Last edited 5 years ago by francois.lacombe (previous) (diff)

comment:21 by Klumbumbus, 4 years ago

Resolution: fixed
Status: reopenedclosed

In 15464/josm:

fix #17984 - deprecate pole:type=anchor|suspension in favor of line_attachment=anchor|suspension

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.