Modify

Opened 4 weeks ago

Closed 2 weeks ago

#17970 closed defect (fixed)

False positive: missing tag - highway without a reference

Reported by: skyper Owned by: team
Priority: normal Milestone: 19.08
Component: Core validator Version: latest
Keywords: template_report ref highway route relation Cc: Klumbumbus

Description

What steps will reproduce the problem?

  1. have a secondary highway as member of a road route relation.
  2. run validator

What is the expected result?

No warning as the ref=* is set in the relation

What happens instead?

False positive.
Info warning: missing tag - highway without a reference

Please provide any additional information below. Attach a screenshot if possible.

Would prefer the other way around, that I get a warning about a way with ref=* and being member of a route relation.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-07-23 21:47:40 +0200 (Tue, 23 Jul 2019)
Build-Date:2019-07-24 01:30:51
Revision:15262
Relative:URL: ^/trunk

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Attachments (0)

Change History (7)

comment:1 Changed 4 weeks ago by skyper

Summary: missing tag - highway without a referenceFalse positive: missing tag - highway without a reference

comment:2 Changed 4 weeks ago by skyper

Unlike multipolygons relations, road relations with incomplete members need to be used for this test !

comment:3 Changed 4 weeks ago by GerdP

I am not sure but I think the common way to tag the ref is to put it on the highway way and - maybe - also on the relation.

comment:4 in reply to:  3 Changed 3 weeks ago by skyper

Replying to GerdP:

I am not sure but I think the common way to tag the ref is to put it on the highway way and - maybe - also on the relation.

At least in my area we treat every route relation the same. e.g. the ref is a tag of the route and not the highway. Adding ref, for example, for bicycle route on the highway is tagging for the renderer. Remember that we already privilege road relations as it is the only route relation rendered on the main map.

So why handle road relations differently ?

comment:5 Changed 3 weeks ago by Don-vip

Milestone: 19.08
Owner: changed from team to Don-vip
Status: newassigned

comment:6 Changed 3 weeks ago by Don-vip

Cc: Klumbumbus added
Owner: changed from Don-vip to team
Status: assignednew

@Klumbumbus it's a mapcss test, if you want to take a look:

way.major_road[!ref][!destination:ref][noref!=yes][junction!=roundabout] {
  throwOther: tr("highway without a reference");
  group: tr("missing tag");
  assertMatch: "way highway=primary";
  assertNoMatch: "way highway=primary ref=123";
  assertNoMatch: "way highway=primary destination:ref=123";
  assertNoMatch: "way highway=primary noref=yes";
}

comment:7 Changed 2 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15285/josm:

fix #17970 - don't warn about missing ref=* on highway=* if it is part of a type=route route=road relation which has a ref=*

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.