Parsing error in i18n script

[Don-vip]

The i18n job fails with this error:

trans_.java:
     [exec] https://josm.openstreetmap.de/josmfile?mode=en
     [exec] Extracting to build/josmfiles

     [exec] /* unparsed line 4     <combo key="direction" de.text="Richtung" values="forward;backward" de.values="Vorwärts;Rückwärts"/> */

The text is here but I'm not sure what the error is:
https://josm.openstreetmap.de/wiki/Presets/traffic_signs_DE

[stoecker]

Well, the script expects that there is a "text" block anywhere. The above will only work for German language setups. In any other case no text will be shown.

Solution: Add English texts :-)

[Klumbumbus]

fixed in https://josm.openstreetmap.de/wiki/Presets/traffic_signs_DE?action=diff&version=5

Not sure if you want to code something preventing this in the future.

[stoecker]

I think it affects all the other de-only texts in this wiki as well :-)

Not sure if you want to code something preventing this in the future.

Don't think so ATM.

[Klumbumbus]

I thought that was the only occourance as the parsing error was new?

[stoecker]

Replying to Klumbumbus:

I thought that was the only occourance as the parsing error was new?

Probably the other lines don't trigger an error and the scripts simply take de.name/de.text as name/text? Anyway the issue is the same there.

[skyper]

+1 for adding other languages in external presets and validator test.

Language barrier is often too high for using them in general. Best would be to warn about no english version.

[stoecker]

Replying to skyper:

+1 for adding other languages in external presets and validator test.

Language barrier is often too high for using them in general. Best would be to warn about no english version.

Feel free to do so. The infrastructure is ready. This error message came from the parser checking the wiki pages. ATM the results of that parsing aren't uploaded to translation facility because of bad overall quality.

What's missing is a cleanup of all the existing wiki pages until a clean set of translatable strings can be extracted. I spent a lot of time to mark foreign language presets and cleanup texts and then lost the motivation as it was still too much to do.

[skyper]

Replying to stoecker:

Replying to skyper:

+1 for adding other languages in external presets and validator test.

Language barrier is often too high for using them in general. Best would be to warn about no english version.

Feel free to do so. The infrastructure is ready. This error message came from the parser checking the wiki pages.

Sorry, might translate some to english but a I do not speak many language well enough to translate them into english. Not speaking about the languages I do not know at all.

We should not have a key for main/default language or warn if it is not english.

ATM the results of that parsing aren't uploaded to translation facility because of bad overall quality.

I was not sure about this fact when adding the bicycle/foot=designated together with foot-/cycleway validator check to the german validator rules. I ended up to only support german.
How about general phrases which are in core already and key word in syntax like suggest? Are they translated ?

[stoecker]

Replying to skyper:

Replying to stoecker:

Replying to skyper:

+1 for adding other languages in external presets and validator test.

Language barrier is often too high for using them in general. Best would be to warn about no english version.

Feel free to do so. The infrastructure is ready. This error message came from the parser checking the wiki pages.

Sorry, might translate some to english but a I do not speak many language well enough to translate them into english. Not speaking about the languages I do not know at all.

We should not have a key for main/default language or warn if it is not english.

The key for the main language essentially excludes foreign language presets from translation. That was part of the cleanup process.

ATM the results of that parsing aren't uploaded to translation facility because of bad overall quality.

I was not sure about this fact when adding the bicycle/foot=designated together with foot-/cycleway validator check to the german validator rules. I ended up to only support german.
How about general phrases which are in core already and key word in syntax like suggest? Are they translated ?

They are translated, but only when 100% matching.