Changes between Initial Version and Version 1 of Ticket #17938, comment 4


Ignore:
Timestamp:
2019-07-24T22:16:29+02:00 (6 years ago)
Author:
Klumbumbus

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17938, comment 4

    initial v1  
    33> How can you add [bridge:movable=retractable] if it's already available to JOSM Validator?
    44
    5 I didn't add the values to the validator directly. I added them to the "Movable bridge" preset. The validator checks all tags if they look "very similar" to the tags in the presets. That test aims to find typos like highway=resident**ai**l. "tilt" looked very similar to "lift" (only one character changed and order changed). Therefore it was reported. "retractable" didn't look very similar to one of the values "bascule,drawbridge,lift,submersible,swing,transporter". Therefore it was not reported. (Deeper theory what "very similar" means see https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java and https://en.wikipedia.org/wiki/Levenshtein_distance)
     5I didn't add the values to the validator directly. I added them to the "Movable bridge" preset. The validator checks all tags if they look "very similar" to the tags in the presets. That test aims to find typos like highway=resident**ai**l. "tilt" looked very similar to "lift" (only one character changed and order changed). Therefore it was reported. "retractable" didn't look very similar to one of the values "bascule,drawbridge,lift,submersible,swing,transporter". Therefore it was not reported. (Deeper theory what "very similar" means see ~~https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java~~ https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java and https://en.wikipedia.org/wiki/Levenshtein_distance)
    66
    77> Isn't a database extract available from OSM Approved that can be completely imported into JOSM validator?