Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#17938 closed defect (fixed)

False positive: Unknown property value - Value 'tilt' for key 'bridge:movable' is unknown, maybe 'lift' is meant?

Reported by: AnkEric Owned by: team
Priority: normal Milestone: 19.08
Component: Core validator Version:
Keywords: bridge movable tilt Cc:

Description

False positive: Unknown property value - Value 'tilt' for key 'bridge:movable' is unknown, maybe 'lift' is meant?

OSM wiki:

https://wiki.openstreetmap.org/wiki/Tag:bridge:movable%3Dtilt

Mapillary image:

https://www.mapillary.com/map/im/EVGi1qUQRtE8ugEas9emSg

These bridges are very effectively used - in the Netherlands - for "bird breeding season closure".

Tags:

  • bridge=movable
  • bridge:movable=tilt

Attachments (0)

Change History (4)

comment:1 Changed 5 weeks ago by Klumbumbus

Milestone: 19.08

comment:2 Changed 5 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15253/josm:

fix #17938 - add bridge:movable=retractable and tilt

comment:3 Changed 5 weeks ago by AnkEric

Thanks!

But please allow me two questions.

fix #17938 - add bridge:movable=retractable and tilt

Curious, since I was sure I have used [bridge:movable=retractable] before. And JOSM validator did not protest.

I even found it:
https://www.openstreetmap.org/changeset/30956629 (5/10/15): [bridge=movable] + [bridge:movable=retractable]
I have just validated again (JOSM 15238) and again: JOSM validator is very happy... no Warning!
How can you add [bridge:movable=retractable] if it's already available to JOSM Validator?

Second question:

Still wondering: why is JOSM validator sometimes missing keys and values that have OSM status = "approved"?
Isn't a database extract available from OSM Approved that can be completely imported into JOSM validator?

Just curious, not important!

comment:4 in reply to:  3 Changed 5 weeks ago by Klumbumbus

Replying to AnkEric:

Curious, since I was sure I have used [bridge:movable=retractable] before. And JOSM validator did not protest.
How can you add [bridge:movable=retractable] if it's already available to JOSM Validator?

I didn't add the values to the validator directly. I added them to the "Movable bridge" preset. The validator checks all tags if they look "very similar" to the tags in the presets. That test aims to find typos like highway=residentail. "tilt" looked very similar to "lift" (only one character changed and order changed). Therefore it was reported. "retractable" didn't look very similar to one of the values "bascule,drawbridge,lift,submersible,swing,transporter". Therefore it was not reported. (Deeper theory what "very similar" means see https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java and https://en.wikipedia.org/wiki/Levenshtein_distance)

Isn't a database extract available from OSM Approved that can be completely imported into JOSM validator?

No.

Last edited 4 weeks ago by Klumbumbus (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.