Multipolygon test possibly wrong

[naoliv]

With the attached example file, where we have the same farm consisting of 2 different plots of land (grouped in the multipolygon), when we validate it we see an error about Multipolygon relation should be tagged with area tags and not the outer ways

One area is a landuse=farmland which is also part of that farm.
For me it seems that, for this case, the error message isn't right.

JOSM:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-07-07 18:36:38 +0200 (Sun, 07 Jul 2019)
Revision:15226
Build-Date:2019-07-07 16:37:55
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15226 en) Linux Debian GNU/Linux 10 (buster)
Memory Usage: 287 MB / 2048 MB (63 MB allocated, but free)
Java version: 11.0.4-ea+10-post-Debian-1, Debian, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.4+10-1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-22
libcommons-compress-java: libcommons-compress-java:all-1.18-2
libcommons-logging-java: libcommons-logging-java:all-1.2-2
VM arguments: [-Dhttps.protocols=TLSv1,TLSv1.1,TLSv1.2, -Dawt.useSystemAAFontSettings=gasp]
Program arguments: [--language=en]
Dataset consistency test: No problems found

[Don-vip]

This warning comes from old style multipolygons check:

                    /* old style multipolygon - solve: copy tags from outer way to multipolygon */
                    errors.add(TestError.builder(this, Severity.ERROR, NO_STYLE_POLYGON)
                            .message(trn("Multipolygon relation should be tagged with area tags and not the outer way",
                                    "Multipolygon relation should be tagged with area tags and not the outer ways",
                                    polygon.getOuterWays().size()))
                            .primitives(r)
                            .build());

Is it still useful? We removed all of them last year no?

[stoecker]

I also believe that old style multipolygons should be gone, so we can probably also drop related tests. They probably also aren't rendered anymore (at least newest osm2pgsql ignores them completely).

[Don-vip]

Yep, they're gone:
​http://area.jochentopf.com/stats/#old_style_multipolygons
​http://area.jochentopf.com/map/

I'm removing this check then.

[Don-vip]

In 15244/josm:

fix #17886 - remove check for old-style multipolygons (removed from OSM database in May 2017)

[stoecker]

That was a fancy project and it was successful. Yeah! I already forgot about it.

[GerdP]

See regression in #19136