Modify

Opened 5 months ago

Closed 5 months ago

#17754 closed defect (fixed)

[Patch] Search dialog input field doesn't react on changes in radio buttons

Reported by: GerdP Owned by: GerdP
Priority: normal Milestone: 19.05
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Open Search dialog in expert mode
  2. Enable button "MapCSS selector"
  3. Type search expression "highway" , note that the input field is marked red
  4. Enable button "standard"

What is the expected result?

Step 4 should remove the red marker as highway is a valid standard search expression

What happens instead?

The red marker is not removed.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-28 04:36:41 +0200 (Sun, 28 Apr 2019)
Build-Date:2019-04-28 02:37:58
Revision:15031
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15031 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 658 MB / 1820 MB (293 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20190524_102711.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ apache-commons (34908)
+ buildings_tools (34982)
+ continuosDownload (82)
+ ejml (34908)
+ geotools (34908)
+ jaxb (34908)
+ jts (34908)
+ o5m (34908)
+ opendata (34997)
+ pbf (34908)
+ poly (34991)
+ reverter (34999)
+ undelete (34977)
+ utilsplugin2 (34977)

Validator rules:
+ c:\josm\core\data\validator\geometry.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (1)

17754.patch (2.8 KB) - added by GerdP 5 months ago.
execute validate() when radio button is selected

Download all attachments as: .zip

Change History (5)

Changed 5 months ago by GerdP

Attachment: 17754.patch added

execute validate() when radio button is selected

comment:1 Changed 5 months ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

Please review the patch. Is that the proper way to do it?

comment:2 Changed 5 months ago by GerdP

Summary: [Patch] Search dialog input filed doesn't react on changes in radio buttons[Patch] Search dialog input field doesn't react on changes in radio buttons

comment:3 Changed 5 months ago by Don-vip

Seems fine.

comment:4 Changed 5 months ago by GerdP

Resolution: fixed
Status: assignedclosed

In 15109/josm:

fix #17754: Search dialog input field doesn't react on changes in radio buttons

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.