recommend migrating from barrier=embankment to man_made=embankment

[mkoniecz]

What steps will reproduce the problem?

1. create way
2. tag it with barrier=embankment
3. run validator

What is the expected result?

Validator recommends migrating to man_made=embankment

What happens instead?

Presets do not contain property value - Value 'embankment' for key 'barrier' not in presets. (1)

Please provide any additional information below. Attach a screenshot if possible.

barrier=embankment was mostly imported

​https://wiki.openstreetmap.org/wiki/Tag:barrier%3Dembankment

in this case usage numbers are quite powerful argument - ​https://wiki.openstreetmap.org/wiki/File:Embankment-man_made-vs-barrier.png

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-22 19:59:40 +0200 (Mon, 22 Apr 2019)
Build-Date:2019-04-23 01:30:52
Revision:15017
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15017 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 439 MB / 869 MB (165 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ buildings_tools (34982)
+ continuosDownload (82)
+ imagery_offset_db (34908)
+ measurement (34977)
+ reverter (34977)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: Invalid jar file ''<josm.userdata>/plugins/imagery_offset_db.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.userdata>/plugins/buildings_tools.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.userdata>/plugins/OpeningHoursEditor.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.userdata>/plugins/measurement.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.userdata>/plugins/reverter.jar.new'' (exists: false, canRead: false)
- W: No configuration settings found.  Using hardcoded default values for all pools.

[anonymous]

"barrier=embankment was mostly imported"

Do you have by chance the link/reference to the corresponding documentation of the main import?

[mkoniecz]

Do you have by chance the link/reference to the corresponding documentation of the main import?

No, though I was not looking hard for it.

[Klumbumbus]

In 15533/josm:

• fix #18343 - don't render man_made=embankment pattern on both sides when used on highway/railway/waterway
• fix #17643 - deprecate barrier=embankment in favor of man_made=embankment

[aceman]

Actually, it looks like JOSM could also warn if man_made=embankment is used together with highway/railway/waterway. In such case embankment=yes/right/left should be used per the wiki: ​https://wiki.openstreetmap.org/wiki/Key:embankment .
man_made=embankment is only to be used alone, if it is the only main feature of the way (OSM object).