Modify

Opened 2 months ago

Closed 6 weeks ago

Last modified 4 weeks ago

#17623 closed enhancement (fixed)

Complain about junction=yes with highway=*

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.05
Component: Core validator Version:
Keywords: template_report Cc: sommerluk

Description

What steps will reproduce the problem?

  1. Create circle with ways
  2. add highway=trunk
  3. add junction=yes (not junction=roundabout or junction=circular)
  4. Run validator

What is the expected result?

Validator complains that junction=yes is supposed to be as node or area including the entire junction

What happens instead?

No validator complaints

Please provide any additional information below. Attach a screenshot if possible.

It may be fairly rare but results are highly confusing as closed way with junction=yes is interpreted as area - note that at the step 3 also JOSM adds area rendering to the highway.

See also https://github.com/gravitystorm/openstreetmap-carto/issues/3753

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-03 00:33:43 +0200 (Wed, 03 Apr 2019)
Build-Date:2019-04-03 01:30:50
Revision:14954
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14954 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 437 MB / 869 MB (289 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34904)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34961)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss to tag checker
- W: java.lang.IllegalArgumentException: Expecting n/node/w/way/r/relation/area, but got '"node'

Attachments (0)

Change History (6)

comment:1 Changed 2 months ago by sommerluk

Cc: sommerluk added

comment:2 Changed 2 months ago by mkoniecz

Maybe more general rule "linear highway without area=yes has tag indicating that it is an area" would be a better idea?

Last edited 2 months ago by mkoniecz (previous) (diff)

comment:3 Changed 6 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15094/josm:

fix #17623 - warn about junction=yes together with highway=* and warn about A linear object highway=* without area=yes has a tag indicating that it is an area.

comment:4 Changed 6 weeks ago by Klumbumbus

I added both. The general rule only as info level as it could be the fault of the active mappaint style(s) instead of the tags.

comment:5 Changed 6 weeks ago by Klumbumbus

Milestone: 19.05

comment:6 Changed 4 weeks ago by Klumbumbus

In 15131/josm:

see #17623 , see #17765 - fix validator warning, don't treat highway=services as linear object

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.