Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17600 closed enhancement (fixed)

[PATCH] turnlanes shouldn't use deprecated functions

Reported by: taylor.smock Owned by: team
Priority: normal Milestone:
Component: Plugin turnlanes Version:
Keywords: Cc:

Description

I converted OsmPrimitive.getFilteredList to Utils.filteredCollection, but I also had to refactor the Utils.java in turnlanes to TurnlanesUtils.java in order to avoid having both Utils stepping on one another.

I don't know if turnlanes is a dependency of other plugins, but I did run find . -name "build.xml" -exec grep -i "turnlane" {} \; and it only came up with turnlanes and turnlanes-tagging.

Attachments (1)

17600.patch​ (15.2 KB ) - added by taylor.smock 6 years ago.
Replace deprecated functions and move Utils.java to TurnlanesUtils.java with appropriate name changes.

Download all attachments as: .zip

Change History (5)

by taylor.smock, 6 years ago

Attachment: 17600.patch​ added

Replace deprecated functions and move Utils.java to TurnlanesUtils.java with appropriate name changes.

comment:2 by Don-vip, 6 years ago

Patch was incomplete, needed [o34978].

comment:3 by Don-vip, 6 years ago

Resolution: → fixed
Status: new → closed

Fixed in [o34979].

comment:4 by taylor.smock, 6 years ago

It was incomplete. I had the changes locally, but I didn't run svn add src/org/openstreetmap/josm/plugins/turnlanes/model/TurnlanesUtils.java for the svn diff command.

Thanks for fixing the patch. I honestly can't wait for #16857 to be completed, since I think it will help me avoid mistakes that I have made working with svn.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.