Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#17594 closed enhancement (fixed)

tracktype=grade2 with surface=sand is always wrong

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: template_report highway track tracktype grade surface sand Cc:

Description

What steps will reproduce the problem?

  1. Tag highway=track tracktype=grade2 surface=sand
  2. Run validator

What is the expected result?

Validator complains that sand surface with tractype=grade2 makes no sense

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

9k+ cases - see http://overpass-turbo.eu/s/HVz

It makes sense to complain also about surface=mud

It may happen as result someone inverting order of tracktypes or if tracktype and surface tags were added separately, maybe years apart.

It makes sense to check it everywhere where both surface and tracktype is tagged, not only on tracks.

#17592 is a very similar one - about broader list of mismatch for grade1

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-03 00:33:43 +0200 (Wed, 03 Apr 2019)
Build-Date:2019-04-03 01:30:50
Revision:14954
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14954 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 440 MB / 869 MB (322 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1366x768
Maximum Screen Size: 1366x768
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34904)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34961)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Failed to add ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss to tag checker
- W: java.lang.IllegalArgumentException: Expecting n/node/w/way/r/relation/area, but got '"node'

Attachments (0)

Change History (3)

comment:1 Changed 6 months ago by Don-vip

Keywords: highway track tracktype grade surface sand added

comment:2 Changed 6 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14987/josm:

  • see #2760 see #13804 - fix validator rule syntax
  • see #17592 - fix validator rule syntax
  • fix #17594 - warn about tracktype=grade2 with surface=sand|mud

comment:3 Changed 6 months ago by Klumbumbus

Milestone: 19.04

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.