Modify

Opened 6 weeks ago

Closed 3 weeks ago

#17584 closed enhancement (fixed)

[PATCH] pt_assistant shouldn't use deprecated methods

Reported by: taylor.smock Owned by: Biswesh
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: Cc:

Description

In the patch, I've converted OsmPrimtive.getFilteredList to Utils.filteredCollection with the appropriate constructors.

I also modified some methods to be static, since that reduced the Problem spam in Eclipse, and I figure that it is always better to mark a method as static than always have to use dynamically.

Attachments (2)

17584.patch (9.0 KB) - added by taylor.smock 6 weeks ago.
Replace deprecated functions and mark some methods as static
17584_remainder.patch (1.1 KB) - added by taylor.smock 6 weeks ago.
Replace OsmPrimitive.getFilteredList with Utils.filteredCollection

Download all attachments as: .zip

Change History (6)

Changed 6 weeks ago by taylor.smock

Attachment: 17584.patch added

Replace deprecated functions and mark some methods as static

comment:2 Changed 6 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

comment:3 Changed 6 weeks ago by taylor.smock

Resolution: fixed
Status: closedreopened

It looks like I missed one in src/main/java/org/openstreetmap/josm/plugins/pt_assistant/utils/StopUtils.java.

I've uploaded the very minimal patch as 17584_remainder.patch.

Changed 6 weeks ago by taylor.smock

Attachment: 17584_remainder.patch added

Replace OsmPrimitive.getFilteredList with Utils.filteredCollection

comment:4 Changed 3 weeks ago by Don-vip

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Biswesh.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.