[Patch] Confusing error message for turn restriction

[GerdP]

What steps will reproduce the problem?

1. Validate attached file

What is the expected result?

Validator should complain that the turn restriction relation 4124998 is not needed because the oneway tags don't allow to travel that way.

What happens instead?

It produces an error message: The "from" way does not start or end at a "via" node which doesn't contain
the relation:

Please provide any additional information below. Attach a screenshot if possible.

Note that the error message points to a new way which doesn't exist in the real data.

Build-Date:2019-04-05 10:37:59
Revision:14962
Is-Local-Build:true

Identification: JOSM/1.5 (14962 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 972 MB / 1753 MB (583 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:51919, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (34949)
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34961)
+ undelete (34919)
+ utilsplugin2 (34932)

Last errors/warnings:
- W: JOSM expected to find primitive [way -197748] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197778] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197807] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197807] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197807] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception

[GerdP]

The attached patch fixes the problem. I've not yet tested the cases were a via way is used. I think I'll add a unit test for this.

[GerdP]

With v2 I've implemented a unit test based on the code in MultipolygonTestTest.
I've added some more problem cases to the already existing file data_nodist/restriction.osm.

Open problem:
Some relations produce similar warnings from RelationTestand from TurnrestrictionTest, sometimes with different severity:

Let me know if I should add code to suppress the less specific warnings from RelationTest
If I hear no complains I'll commit the patch on Sunday.

[GerdP]

suppress warnings for role location_hint

[GerdP]

suppress less specific warnings from RelationChecker when TurnrestrictionTest is enabled

[GerdP]

In 14966/josm:

fix #17561 Confusing error message for turn restriction
fix #17567 rephrase warning for role location_hint in restriction relation

• improve validator messages for restriction relations
• suppress duplicate warnings for wrong roles from RelationChecker when TurnrestrictionTest is enabled
• add unit test for TurnrestrictionTest similar to the one for MultipolygonTest