Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#17561 closed defect (fixed)

[Patch] Confusing error message for turn restriction

Reported by: GerdP Owned by: GerdP
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by GerdP)

What steps will reproduce the problem?

  1. Validate attached file

What is the expected result?

Validator should complain that the turn restriction relation 4124998 is not needed because the oneway tags don't allow to travel that way.

What happens instead?

It produces an error message: The "from" way does not start or end at a "via" node which doesn't contain
the relation:

Please provide any additional information below. Attach a screenshot if possible.

Note that the error message points to a new way which doesn't exist in the real data.

Build-Date:2019-04-05 10:37:59
Revision:14962
Is-Local-Build:true

Identification: JOSM/1.5 (14962 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 972 MB / 1753 MB (583 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:51919, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (34949)
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34961)
+ undelete (34919)
+ utilsplugin2 (34932)

Last errors/warnings:
- W: JOSM expected to find primitive [way -197748] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197778] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197807] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197807] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way -197807] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception

Attachments (7)

sample.osm (43.3 KB) - added by GerdP 6 months ago.
pic1.PNG (12.4 KB) - added by GerdP 6 months ago.
17561.diff (4.5 KB) - added by GerdP 6 months ago.
17561-v2.patch (117.4 KB) - added by GerdP 6 months ago.
dup.msg.png (7.3 KB) - added by GerdP 6 months ago.
17561-v3.patch (120.8 KB) - added by GerdP 6 months ago.
suppress warnings for role location_hint
17561-v4.patch (122.4 KB) - added by GerdP 6 months ago.
suppress less specific warnings from RelationChecker when TurnrestrictionTest is enabled

Download all attachments as: .zip

Change History (14)

Changed 6 months ago by GerdP

Attachment: sample.osm added

Changed 6 months ago by GerdP

Attachment: pic1.PNG added

comment:1 Changed 6 months ago by GerdP

Component: CoreCore validator
Description: modified (diff)

comment:2 Changed 6 months ago by GerdP

Summary: Confusing error messageConfusing error message for turn restriction

Changed 6 months ago by GerdP

Attachment: 17561.diff added

comment:3 Changed 6 months ago by GerdP

Summary: Confusing error message for turn restriction[Patch] Confusing error message for turn restriction

The attached patch fixes the problem. I've not yet tested the cases were a via way is used. I think I'll add a unit test for this.

comment:4 Changed 6 months ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

Changed 6 months ago by GerdP

Attachment: 17561-v2.patch added

Changed 6 months ago by GerdP

Attachment: dup.msg.png added

comment:5 Changed 6 months ago by GerdP

With v2 I've implemented a unit test based on the code in MultipolygonTestTest.
I've added some more problem cases to the already existing file data_nodist/restriction.osm.

Open problem:
Some relations produce similar warnings from RelationTestand from TurnrestrictionTest, sometimes with different severity:

Let me know if I should add code to suppress the less specific warnings from RelationTest
If I hear no complains I'll commit the patch on Sunday.

Changed 6 months ago by GerdP

Attachment: 17561-v3.patch added

suppress warnings for role location_hint

Changed 6 months ago by GerdP

Attachment: 17561-v4.patch added

suppress less specific warnings from RelationChecker when TurnrestrictionTest is enabled

comment:6 Changed 6 months ago by GerdP

Resolution: fixed
Status: assignedclosed

In 14966/josm:

fix #17561 Confusing error message for turn restriction
fix #17567 rephrase warning for role location_hint in restriction relation

  • improve validator messages for restriction relations
  • suppress duplicate warnings for wrong roles from RelationChecker when TurnrestrictionTest is enabled
  • add unit test for TurnrestrictionTest similar to the one for MultipolygonTest

comment:7 Changed 6 months ago by Don-vip

Milestone: 19.04

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.