Modify

Opened 3 weeks ago

Closed 3 weeks ago

#17554 closed enhancement (fixed)

Stronger warning with keys ending with a number

Reported by: naoliv Owned by: team
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: Cc:

Description

Have the attached example validated, where we have this:

landuse=grass
landuse_1=recreation_ground
landuse_2=recreation
landuse_3=greenfield
leisure=park
leisure_1=garden
leisure_2=grass
leisure_3=playground
name=Parque da Cidade
natural=wood
natural_1=scrub
natural_2=grassland

It's clear that all these _1, _2, _3 tags are invalid (or, at least, far from being the proper way to represent the object) but JOSM only gives some informational level messages about this:

https://i.imgur.com/bURZcmf.png

Shouldn't we be seeing more messages about questionable tags, and at the warning level?

JOSM:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-02 01:24:27 +0200 (Tue, 02 Apr 2019)
Revision:14953
Build-Date:2019-04-02 01:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14953 en) Linux Debian GNU/Linux buster/sid
Memory Usage: 304 MB / 2048 MB (79 MB allocated, but free)
Java version: 11.0.3+4-Debian-3, Debian, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.3+4-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21
VM arguments: [-Dhttps.protocols=TLSv1,TLSv1.1,TLSv1.2, -Dawt.useSystemAAFontSettings=gasp]
Program arguments: [--language=en]
Dataset consistency test: No problems found

Attachments (1)

example.osm (10.2 KB) - added by naoliv 3 weeks ago.

Download all attachments as: .zip

Change History (3)

Changed 3 weeks ago by naoliv

Attachment: example.osm added

comment:1 Changed 3 weeks ago by Klumbumbus

Milestone: 19.04

As there was no clear consensus back in the days about number suffixes when iD invented this it was added as information instead of warning. See discussion in #12494. However since iD recently choose to revert this behavior, I think it is fine to raise it to warning level now.

The problem that only one _# tag is marked as questionable key is because every mapcss rule is executed only once. When a match is found it doesn't check more tags of the same object but prints the warning. When you remove leisure_1 in your example and run the validator again you will get the warning for the next matching tag. You have to repeat these steps until all _# tags of this object are defeated ;)

Last edited 3 weeks ago by Klumbumbus (previous) (diff)

comment:2 Changed 3 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14957/josm:

fix #17554, see #12494 - raise "questionable key (ending with a number)" to warning level

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.