shop=underwear autofix

[mkoniecz]

What steps will reproduce the problem?

1. tag shop=underwear node
2. run validator

What is the expected result?

Autofix offered.

What happens instead?

Autofix not offered.

Please provide any additional information below. Attach a screenshot if possible.

patch is available at ​https://github.com/matkoniecz/josm/commit/98a961a18e5d106e037407eea420a27db1341007.patch

*[shop=underwear] {
  throwWarning: tr("{0} is deprecated", "{0.tag}");
  suggestAlternative: "shop=clothes clothes=underwear";
  group: tr("deprecated tagging");
  fixAdd: "shop=clothes";
  fixAdd: "clothes=underwear";
}

​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dunderwear

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-24 22:30:59 +0100 (Sun, 24 Mar 2019)
Build-Date:2019-03-25 02:30:52
Revision:14927
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14927 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 413 MB / 869 MB (180 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34904)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34946)
+ todo (30306)

Validator rules:
+ ${HOME}/Desktop/tmp/unnecessary.validator.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[Don-vip]

There is not even 100 objects with this tag. It's simpler to fix the tags manually one time, using an overpass query. Errors must be common to be addressed in JOSM core.

[mkoniecz]

I thought that it would be useful also for people trying to use this tag in future, but I understand keeping rarely used tags off limits.