Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#17471 closed enhancement (fixed)

complain about name=АЗС on amenity=fuel

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.03
Component: Core validator Version:
Keywords: amenity fuel name a3c Cc:

Attachments (0)

Change History (8)

comment:1 Changed 5 weeks ago by Don-vip

Keywords: amenity fuel name a3c added
Milestone: 19.03

comment:2 Changed 5 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 14891/josm:

fix #17471 - complain about name=АЗС on amenity=fuel

comment:3 Changed 5 weeks ago by mkoniecz

Note that

АЗС

and

A3C

is not the same (try ctrl-f). One is using Cyrillic letters and one not. Complaining about ASCII version probably makes sense (to avoid switching to a camouflaged version of a descriptive name), but Cyrillic variant is one widely used. A3C that was added to a validator is used just 18 times, АЗС is used 600+ times.

And yes, it is confusing. See https://en.wikipedia.org/wiki/IDN_homograph_attack

Last edited 5 weeks ago by mkoniecz (previous) (diff)

comment:4 Changed 5 weeks ago by mkoniecz

Resolution: fixed
Status: closedreopened

comment:5 Changed 5 weeks ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 14893/josm:

fix #17471 - use cyrillic characters for name=АЗС

comment:6 Changed 5 weeks ago by GerdP

Resolution: fixed
Status: closedreopened

This seems to cause problems:

2019-03-17 18:04:46.923 FINE: Adding resource://data/validator/deprecated.mapcss to tag checker
2019-03-17 18:04:47.009 SEVERE: Skipping to the next rule, because of an error:
2019-03-17 18:04:47.016 SEVERE: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " <UNEXPECTED_CHAR> "\u0410 "" at line 456, column 8.
Was expecting one of:
    "set" ...
    <IDENT> ...
    <UINT> ...
    <STRING> ...
    "(" ...
    <UFLOAT> ...
    <HEXCOLOR> ...
    <S> ...
    "=" ...
    "!" ...
    "+" ...
    "-" ...
    "/*" ...
    <S> ...
    "-" ...
    <UINT> ...
    "-" ...
    <UFLOAT> ...
    <UINT> ...
    <IDENT> ...
    "set" ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <IDENT> ...
    "set" ...
org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " <UNEXPECTED_CHAR> "\u0410 "" at line 456, column 8.
Was expecting one of:
    "set" ...
    <IDENT> ...
    <UINT> ...
    <STRING> ...
    "(" ...
    <UFLOAT> ...
    <HEXCOLOR> ...
    <S> ...
    "=" ...
    "!" ...
    "+" ...
    "-" ...
    "/*" ...
    <S> ...
    "-" ...
    <UINT> ...
    "-" ...
    <UFLOAT> ...
    <UINT> ...
    <IDENT> ...
    "set" ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <IDENT> ...
    "set" ...
    
	at org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.MapCSSParser.error_skipto(MapCSSParser.java:2160)
	at org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.MapCSSParser.sheet(MapCSSParser.java:896)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$TagCheck.readMapCSS(MapCSSTagChecker.java:533)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker.addMapCSS(MapCSSTagChecker.java:930)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker.initialize(MapCSSTagChecker.java:959)
	at org.openstreetmap.josm.data.validation.OsmValidator.initializeTests(OsmValidator.java:585)
	at org.openstreetmap.josm.data.validation.OsmValidator.initializeTests(OsmValidator.java:568)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

comment:7 Changed 5 weeks ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 14896/josm:

fix #17471 - Unicode characters must be quoted

comment:8 Changed 5 weeks ago by Klumbumbus

In 14911/josm:

fix #17100, see #17471 - add name=silo|rumah|jalan to descriptive name warning, move АЗС there too, disable autofix for cases where the value of the name tag could be the value of the other tag (manual fix by human required in these cases)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.