complain about name=АЗС on amenity=fuel

[mkoniecz]

It is generic term for fuel station.

See ​http://overpass-turbo.eu/s/H4E ​https://github.com/osmlab/name-suggestion-index/issues/2479

[Don-vip]

In 14891/josm:

fix #17471 - complain about name=АЗС on amenity=fuel

[mkoniecz]

Note that

АЗС

and

A3C

is not the same (try ctrl-f). One is using Cyrillic letters and one not. Complaining about ASCII version probably makes sense (to avoid switching to a camouflaged version of a descriptive name), but Cyrillic variant is one widely used. A3C that was added to a validator is used just 18 times, АЗС is used 600+ times.

And yes, it is confusing. See ​https://en.wikipedia.org/wiki/IDN_homograph_attack

[Don-vip]

In 14893/josm:

fix #17471 - use cyrillic characters for name=АЗС

[GerdP]

This seems to cause problems:

2019-03-17 18:04:46.923 FINE: Adding resource://data/validator/deprecated.mapcss to tag checker
2019-03-17 18:04:47.009 SEVERE: Skipping to the next rule, because of an error:
2019-03-17 18:04:47.016 SEVERE: org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " <UNEXPECTED_CHAR> "\u0410 "" at line 456, column 8.
Was expecting one of:
    "set" ...
    <IDENT> ...
    <UINT> ...
    <STRING> ...
    "(" ...
    <UFLOAT> ...
    <HEXCOLOR> ...
    <S> ...
    "=" ...
    "!" ...
    "+" ...
    "-" ...
    "/*" ...
    <S> ...
    "-" ...
    <UINT> ...
    "-" ...
    <UFLOAT> ...
    <UINT> ...
    <IDENT> ...
    "set" ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <IDENT> ...
    "set" ...
org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.ParseException: Encountered " <UNEXPECTED_CHAR> "\u0410 "" at line 456, column 8.
Was expecting one of:
    "set" ...
    <IDENT> ...
    <UINT> ...
    <STRING> ...
    "(" ...
    <UFLOAT> ...
    <HEXCOLOR> ...
    <S> ...
    "=" ...
    "!" ...
    "+" ...
    "-" ...
    "/*" ...
    <S> ...
    "-" ...
    <UINT> ...
    "-" ...
    <UFLOAT> ...
    <UINT> ...
    <IDENT> ...
    "set" ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <STRING> ...
    <IDENT> ...
    "set" ...
    
	at org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.MapCSSParser.error_skipto(MapCSSParser.java:2160)
	at org.openstreetmap.josm.gui.mappaint.mapcss.parsergen.MapCSSParser.sheet(MapCSSParser.java:896)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$TagCheck.readMapCSS(MapCSSTagChecker.java:533)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker.addMapCSS(MapCSSTagChecker.java:930)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker.initialize(MapCSSTagChecker.java:959)
	at org.openstreetmap.josm.data.validation.OsmValidator.initializeTests(OsmValidator.java:585)
	at org.openstreetmap.josm.data.validation.OsmValidator.initializeTests(OsmValidator.java:568)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

[Don-vip]

In 14896/josm:

fix #17471 - Unicode characters must be quoted

[Klumbumbus]

In 14911/josm:

fix #17100, see #17471 - add name=silo|rumah|jalan to descriptive name warning, move АЗС there too, disable autofix for cases where the value of the name tag could be the value of the other tag (manual fix by human required in these cases)