Modify

Opened 6 weeks ago

Last modified 5 weeks ago

#17458 assigned defect

False positive warnings at roundabout nodes

Reported by: Klumbumbus Owned by: abalosc1
Priority: normal Milestone:
Component: External rule Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. load data around https://www.openstreetmap.org/way/22912249
  2. validate
  3. warnings OSMOSE - Missing oneway
  4. warnings OSMOSE 3010 - highway roundabout - Roundabout crossing
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-12 00:36:05 +0100 (Tue, 12 Mar 2019)
Build-Date:2019-03-12 02:30:49
Revision:14880
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14880 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1803 (17134)
Memory Usage: 1203 MB / 1820 MB (365 MB allocated, but free)
Java version: 1.8.0_202-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=59567, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (34867)
+ HouseNumberTaggingTool (34867)
+ OpeningHoursEditor (34867)
+ PicLayer (34867)
+ apache-commons (34506)
+ apache-http (34632)
+ buildings_tools (34904)
+ editgpx (34867)
+ ejml (34389)
+ geojson (116)
+ geotools (34513)
+ imagery-xml-bounds (34803)
+ imagery_offset_db (34867)
+ jna (34867)
+ jogl (1.2.2)
+ jts (34524)
+ log4j (34527)
+ measurement (34867)
+ photo_geotagging (34867)
+ photoadjust (34867)
+ reltoolbox (34867)
+ reverter (34917)
+ rex (49)
+ tag2link (34867)
+ tageditor (34867)
+ tagging-preset-tester (34678)
+ terracer (34867)
+ turnlanes-tagging (280)
+ turnrestrictions (34867)
+ undelete (34919)
+ utilsplugin2 (34915)
+ wikipedia (v1.1.1)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1
+ %UserProfile%\Documents\OSM\josm\data\defaultpresets.xml
+ %UserProfile%\Documents\OSM\TestNew\newpresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/PhilippinesAddresses&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1

Map paint styles:
+ %UserProfile%\Documents\OSM\josm\styles\standard\elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
- %UserProfile%\Documents\OSM\TestNew\newicons.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ShowID&zip=1
- %UserProfile%\Documents\OSM\eigene styles\PriorityRoad\PriorityRoad_1.0.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&style&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- %UserProfile%\Documents\OSM\eigene styles\Tourenplanung.mapcss
- %UserProfile%\Documents\OSM\eigene styles\SpecificBuildingValues\SpecificBuildingValues.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- %UserProfile%\Documents\OSM\eigene styles\area-symbol.zip
- http://www.freietonne.de/ft_icons/josm/FreieTonne_rules_presets_zip.php
- http://www.openrailwaymap.org/styles/standard.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1
- https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/hazmat&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Suburb&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/RecyclingMaterials&zip=1
- %UserProfile%\Documents\OSM\eigene styles\maxspeed\maxspeed_2.9_01 basierend auf 2.7_02 Zahlen.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- %UserProfile%\Documents\OSM\eigene styles\colourtag\colourtag_1.0.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/ColourTag&zip=1
- %UserProfile%\Downloads\coloured_kerbs_style.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- %UserProfile%\Desktop\cycle.mapcss

Validator rules:
+ https://raw.githubusercontent.com/<user.name>n-a-bauer/josm-validators/master/mtb.validator.mapcss
- %UserProfile%\Documents\OSM\TestNew\germ.validator.mapcss
- https://josm.openstreetmap.de/josmfile?page=Rules/CzechRepublicAddressSystem&zip=1
+ %UserProfile%\Documents\OSM\TestNew\new.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1

Attachments (0)

Change History (7)

comment:1 Changed 5 weeks ago by dmanzer95

working on a fix for the roundabout crossing. Are the missing oneway warnings really false positives? shouldn't an additional carriageway be mapped entering/exiting the roundabout?

comment:2 in reply to:  1 Changed 5 weeks ago by Klumbumbus

Replying to dmanzer95:

shouldn't an additional carriageway be mapped entering/exiting the roundabout?

No, thats not mandatory.

comment:3 Changed 5 weeks ago by dmanzer95

okay. Also, I thought that roads should be mapped to the centerline. If this is true, then the natural=scrub feature is mapped incorrectly where it is connected to the roundabout. Should we be making exceptions in the validation rule for these types of scenarios? Thanks in advance for the explanation

Last edited 5 weeks ago by dmanzer95 (previous) (diff)

comment:4 Changed 5 weeks ago by Klumbumbus

Most people (including me) don't like that mapping style (area features glued on linear features). Anyway it's not the fault of the roundabout ;)

comment:5 Changed 5 weeks ago by mkoniecz

I thought that roads should be mapped to the centerline. If this is true, then the natural=scrub feature is mapped incorrectly where it is connected to the roundabout.

Yes, gluing natural=scrub to roads is always bad.

It is absolutely always indicating rough approximation (road line is centerline) and what worse it makes further editing overcomplicated.

comment:6 Changed 5 weeks ago by dmanzer95

To address Klumbumbus' point: I agree that it isn't the roundabout's fault and i'll make that change to eliminate false positives of this nature.

addressing mkoniecz: is this agreed upon enough in the OSM community that a separate validation check would be beneficial?

comment:7 Changed 5 weeks ago by mkoniecz

addressing mkoniecz: is this agreed upon enough in the OSM community that a separate validation check would be beneficial?

At least in Poland there is a clear agreement that gluing roads to natural=, landuse= is a bad idea.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain abalosc1.
as The resolution will be set.
to The owner will be changed from abalosc1 to the specified user.
The owner will change to Klumbumbus
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.