Modify

Opened 6 years ago

Closed 6 years ago

#17456 closed defect (fixed)

EDT violation

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Plugin undelete Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Set preference debug.checkDeleteReferenced to false
  2. use reverter to revert CS 47770943 (should end with 226 conflicts)
  3. search for "type:way deleted" with checkbox "all objects" activated, this should show 3 ways in the selection list
  4. Alt+Shift+U to undelete these ways to a new layer: w120591203 w486727370 w107997507
  5. Click OK

What is the expected result?

new layer with 3 ways

What happens instead?

JOSM seems to hang, console shows

EDT violation detected
javax.swing.JMenu$1[,0,0,0x0,invalid,disabled,alignmentX=0.0,alignmentY=0.0,border=javax.swing.plaf.basic.BasicBorders$MarginBorder@5886ed8b,flags=384,maximumSize=,minimumSize=,preferredSize=,defaultIcon=javax.swing.ImageIcon@222ee35d,disabledIcon=,disabledSelectedIcon=,margin=javax.swing.plaf.InsetsUIResource[top=0,left=0,bottom=0,right=0],paintBorder=false,paintFocus=false,pressedIcon=,rolloverEnabled=false,rolloverIcon=,rolloverSelectedIcon=,selectedIcon=,text=Zoom to conflict]
	at java.lang.Thread.getStackTrace(Thread.java:1559)
	at org.jdesktop.swinghelper.debug.CheckThreadViolationRepaintManager.checkThreadViolations(CheckThreadViolationRepaintManager.java:70)
	at org.jdesktop.swinghelper.debug.CheckThreadViolationRepaintManager.addDirtyRegion(CheckThreadViolationRepaintManager.java:61)
	at javax.swing.JComponent.repaint(JComponent.java:4793)
	at java.awt.Component.repaint(Component.java:3311)
	at javax.swing.JComponent.setEnabled(JComponent.java:2683)
	at javax.swing.AbstractButton.setEnabled(AbstractButton.java:2091)
	at javax.swing.JMenuItem.setEnabled(JMenuItem.java:312)
	at javax.swing.AbstractAction.setEnabledFromAction(AbstractAction.java:102)
	at javax.swing.AbstractButton.actionPropertyChanged(AbstractButton.java:1218)
	at javax.swing.JMenuItem.actionPropertyChanged(JMenuItem.java:411)
	at javax.swing.AbstractButton$ButtonActionPropertyChangeListener.actionPropertyChanged(AbstractButton.java:1364)
	at javax.swing.AbstractButton$ButtonActionPropertyChangeListener.actionPropertyChanged(AbstractButton.java:1352)
	at javax.swing.ActionPropertyChangeListener.propertyChange(ActionPropertyChangeListener.java:88)
	at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
	at javax.swing.event.SwingPropertyChangeSupport.firePropertyChange(SwingPropertyChangeSupport.java:92)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
	at javax.swing.AbstractAction.firePropertyChange(AbstractAction.java:276)
	at javax.swing.AbstractAction.setEnabled(AbstractAction.java:236)
	at org.openstreetmap.josm.actions.AutoScaleAction.updateEnabledState(AutoScaleAction.java:441)
	at org.openstreetmap.josm.actions.AutoScaleAction$MapFrameAdapter.lambda$0(AutoScaleAction.java:496)
	at javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:184)
	at javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:164)
	at javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:211)
	at javax.swing.DefaultListSelectionModel.changeSelection(DefaultListSelectionModel.java:405)
	at javax.swing.DefaultListSelectionModel.changeSelection(DefaultListSelectionModel.java:415)
	at javax.swing.DefaultListSelectionModel.removeSelectionIntervalImpl(DefaultListSelectionModel.java:576)
	at javax.swing.DefaultListSelectionModel.clearSelection(DefaultListSelectionModel.java:420)
	at javax.swing.JList.clearSelection(JList.java:2049)
	at org.openstreetmap.josm.gui.dialogs.ConflictDialog.selectionChanged(ConflictDialog.java:332)
	at org.openstreetmap.josm.data.osm.DataSet.lambda$5(DataSet.java:684)
	at org.openstreetmap.josm.tools.ListenerList.fireEvent(ListenerList.java:150)
	at org.openstreetmap.josm.data.osm.DataSet.doSelectionChange(DataSet.java:684)
	at org.openstreetmap.josm.data.osm.DataSet.setSelected(DataSet.java:615)
	at org.openstreetmap.josm.data.osm.DataSet.setSelected(DataSet.java:606)
	at org.openstreetmap.josm.plugins.undelete.UndeleteAction$Worker.run(UndeleteAction.java:208)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Please provide any additional information below. Attach a screenshot if possible.

I think I already found a fix.

Build-Date:2019-03-12 08:41:54
Revision:14880
Is-Local-Build:true

Identification: JOSM/1.5 (14880 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 576 MB / 1753 MB (329 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:59890, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34917)
+ undelete (34883)
+ utilsplugin2 (34915)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (0)

Change History (1)

comment:1 by GerdP, 6 years ago

Resolution: fixed
Status: newclosed

(hopefully) fixed with [o34919:34920]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.