Complain about shop=general and shop=general_store as duplicate of shop=supermarket and shop=convenience

[mkoniecz]

What steps will reproduce the problem?

1. Create node with shop=general tag
2. Run validator

What is the expected result?

Validator informs editor that shop=convenience or shop=supermarket or shop=country_store should be used instead.

What happens instead?

Presets do not contain property value - Value 'general' for key 'shop' not in presets. (1)

Please provide any additional information below. Attach a screenshot if possible.

shop=general is clearly documented as a horrible idea at ​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dgeneral

This tag is a little unclear, partly because of the massive overlap with shop=supermarket and shop=convenience described below, and partly because of the two different usages of the term in the UK and US:

I think that it should be target of validator complaints.

This ticket requests partial opposite of https://josm.openstreetmap.de/ticket/16654

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-02-23 17:46:51 +0100 (Sat, 23 Feb 2019)
Build-Date:2019-02-24 02:30:49
Revision:14802
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14802 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 607 MB / 869 MB (93 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34867)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34867)
+ todo (30306)

Validator rules:
+ ${HOME}/Desktop/tmp/test.validator.mapcss

Last errors/warnings:
- W: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/test.validator.mapcss
- W: Unable to delete archived backup file <josm.userdata>/autosave/deleted_layers/Data Layer 1_20190306_085835182.osm
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: Already here java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out

[Klumbumbus]

I would prefer if the wiki will be changed first.

[mkoniecz]

I changed tone in the wiki - ​https://wiki.openstreetmap.org/w/index.php?title=Tag:shop%3Dgeneral&diff=1820453&oldid=1806002

Lets wait whatever anybody protests on Wiki, mailing list or in this ticket.

[mkoniecz]

shop=general_store appears to have the same meaning.

[mkoniecz]

I started discussion on tagging mailing list to confirm my conclusions.

[mkoniecz]

some may be correctly tagged, some even if most should be retagged it is not feasible to complain in validator