Buildings_tools cannot place buildings where walls meet

[anonymous]

What steps will reproduce the problem?

1. Press B to use the building drawing tool
2. Draw a building where one of the walls end very close to another building

What is the expected result?

Building placed.

What happens instead?

Error message "Cannot place building outside of the world". Sometimes building will place, but with strange geometry. Seems to depend on the direction of the building.

Please provide any additional information below. Attach a screenshot if possible.

Placing buildings like this was possible in a previous version of the plugin/JOSM, but I'm not sure when it changed.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-02-02 21:01:18 +0100 (Sat, 02 Feb 2019)
Build-Date:2019-02-04 21:50:11
Revision:14760
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14760 en) Linux Manjaro Linux
Memory Usage: 2109 MB / 3564 MB (924 MB allocated, but free)
Java version: 1.8.0_202-b26, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1200
Maximum Screen Size: 1920x1200
VM arguments: [-Djosm.restart=true, -Dawt.useSystemAAFontSettings=gasp]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (34867)
+ ImportImagePlugin (34576)
+ OpeningHoursEditor (34867)
+ PicLayer (34867)
+ apache-commons (34506)
+ apache-http (34632)
+ areaselector (349)
+ austriaaddresshelper (57)
+ buildings_tools (34867)
+ ejml (34389)
+ geotools (34513)
+ imagery_offset_db (34867)
+ jaxb (34678)
+ jna (34867)
+ jts (34524)
+ log4j (34527)
+ measurement (34867)
+ opendata (34867)
+ pt_assistant (2.1.10)
+ reverter (34867)
+ tageditor (34867)
+ terracer (34867)
+ turnlanes-tagging (280)
+ turnrestrictions (34867)
+ utilsplugin2 (34867)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[GerdP]

Are you trying to draw a building near longitude 180?

[anonymous]

Nope, mostly drawing in (southern) Sweden.

[anonymous]

I am using another projection than Mercator though (SWEREF 99).

[GerdP]

Ah, okay, I can reproduce it with that projection, but I am also unable to draw anything else?

[anonymous]

I think it's very dependent on in which area you're drawing. The projections only cover a limited area. Try for example near Jönköping.

[GerdP]

Hm, yes, seems something is with the translation between cursor position and projected coordinates. I did not see the error message here but I see that the lines are flipping.

[GerdP]

regression from changes for #16948. No idea yet where to fix it.

[GerdP]

The attached patch seems to fix the problem. I'll commit it tomorrow if nobody complains.

[anonymous]

Good work, thanks for solving it (hopefully)!

[GerdP]

Fixed with [o34904:34905]