Modify

Opened 2 months ago

Last modified 2 months ago

#17350 new defect

Autosave makes JOSM think layer is saved

Reported by: ShadowFoxNixill Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report autosave Cc:

Description

What steps will reproduce the problem?

  1. Open a map from an existing file (make sure "Discourage upload" is turned on)
  2. Make some modifications
  3. Wait for JOSM to autosave

What is the expected result?

JOSM should act as if the file hasn't been saved, as it actually hasn't (the autosave goes to a backup file). This means:
Title bar: Should display an asterisk
Attempting to close JOSM or remove the layer: Should prompt you to save the layer first

What happens instead?

JOSM acts as if a regular save to the file being modified has occurred, meaning:
Title bar: Doesn't display an asterisk
Attempting to close JOSM or remove the layer: Does so without any prompt

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-02-15 20:59:09 +0100 (Fri, 15 Feb 2019)
Build-Date:2019-02-16 02:30:55
Revision:14790
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14790 en) Windows 10 64-Bit
OS Build number: Windows 10 Education 1803 (17134)
Memory Usage: 1997 MB / 1997 MB (869 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080, \Display1 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\Programs\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=62966, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (34506)
+ continuosDownload (82)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ opendata (34867)
+ pbf (34867)
+ utilsplugin2 (34867)

Map paint styles:
+ https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Tags to paste are not valid.
- W: java.io.IOException: Tags to paste are not valid.
- W: JOSM expected to find primitive [way 42372917] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: JOSM expected to find primitive [way 42372917] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception

Attachments (0)

Change History (2)

comment:1 Changed 2 months ago by Don-vip

Keywords: autosave added

comment:2 Changed 2 months ago by Klumbumbus

If I remeber corrctly this is not related to autosave. JOSM never checks for changes in layers with upload=no (which should be changed in my opinion. There should already be a ticket for this somewhere.)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to ShadowFoxNixill
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.