Modify

Opened 2 months ago

Closed 7 weeks ago

Last modified 6 weeks ago

#17345 closed enhancement (fixed)

[PATCH] ValidatorDialog: Ignore button should be disabled sometimes

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.03
Component: Core validator Version:
Keywords: Cc:

Description (last modified by GerdP)

If you run validator and it shows a list of errors or warnings, you can select the entry "Errors" or "Warnings". This will enable the Ignore Button. Clicking on this button has rather unpredictable effects
and therefore the button should be disabled unless a specific type of error is selected.
Load the attached sample.osm and run validator. You shoud get a list similar to
If you left click on Warnings the ignore button is enabled. If you click it the resulting ignore list contains

3000
303


If you select the two different types of warning and click Ignore you'll get

3000_*[amenity=place_of_worship][!religion]
303

Note that the first list will ignore all errors reported by MapCSSTagChecker while the second one is much more specific. Both will not ignore "all warnings" although that would be what I would expect to happen.
My conclusion: The button should be disabled unless the selection contains a specific error.

Attachments (5)

ignorebutton.PNG (9.4 KB) - added by GerdP 2 months ago.
sample.osm (180.6 KB) - added by GerdP 2 months ago.
ignorebutton-2.PNG (12.7 KB) - added by GerdP 2 months ago.
17345.patch (4.2 KB) - added by GerdP 7 weeks ago.
OH.PNG (30.1 KB) - added by GerdP 7 weeks ago.

Download all attachments as: .zip

Change History (10)

Changed 2 months ago by GerdP

Attachment: ignorebutton.PNG added

Changed 2 months ago by GerdP

Attachment: sample.osm added

Changed 2 months ago by GerdP

Attachment: ignorebutton-2.PNG added

comment:1 Changed 2 months ago by GerdP

Description: modified (diff)

comment:2 Changed 2 months ago by Klumbumbus

Component: CoreCore validator

Changed 7 weeks ago by GerdP

Attachment: 17345.patch added

Changed 7 weeks ago by GerdP

Attachment: OH.PNG added

comment:3 Changed 7 weeks ago by GerdP

Milestone: 19.03
Summary: ValidatorDialog: Ignore button should be disabled sometimes[PATCH] ValidatorDialog: Ignore button should be disabled sometimes

The attached patch disables the Ignore button when the selected node has a depth > 1. Up to now I found only one glitch:
The TestError instances produced by OpeningHourTest are a bit special as they have very individual texts:

Without the patch the ignore button would be enabled and pressing it means that code 2901 is added to the ignore list, with the patch
one gets this very specific entry:
2901_opening_hours - Mo 08:00-12:00, 13:00-18:00; Di 08:00-12:00, 13:00-17:00; Mi 08:00-12:00, 13:00-18:00; Do <--- (Bitte benutze die englische Abkürzung "Th" für "do".)

While 2901 is probably too generic the latter more specific pattern is probably too specific.

comment:4 Changed 7 weeks ago by GerdP

Resolution: fixed
Status: newclosed

In 14825/josm:

fix #17345: ValidatorDialog: Ignore button should be disabled sometimes

comment:5 Changed 6 weeks ago by GerdP

In 14858/josm:

see #17345: disable ignore button only when the top level (severity) entry is selected
This partly reverts r14825 as it also caused problems with other tests which create different description texts depending on the object(s).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.