Modify

Opened 2 months ago

Closed 7 weeks ago

Last modified 5 weeks ago

#17342 closed enhancement (fixed)

[Patch] ValidatorDialog: Lookup button needs improvement

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.03
Component: Core validator Version:
Keywords: Cc:

Description (last modified by GerdP)

1) It is nearly always enabled but it is only useful when the seection list is not empty and at least one entry is visible in the Validation Results Panel. It took me years to find out what this button is meant to do because I clicked on it without having selected anything and got no reaction.
2) When the selected OSM element appears in the error list the "Lookup" button should not only mark the corresponding entries but also "jump" to the first entry. A repeated click might loop through further occurences (in other errors)
3) If the selected element(s) are not in the error list maybe show a "not found" popup or simply disable the button in the first place.

Attachments (2)

17342.patch (3.5 KB) - added by GerdP 7 weeks ago.
enable/disable Lookup button
17342-v2.patch (4.7 KB) - added by GerdP 7 weeks ago.
call JTree.scrollPathToVisible()

Download all attachments as: .zip

Change History (9)

comment:1 Changed 2 months ago by GerdP

Description: modified (diff)

Changed 7 weeks ago by GerdP

Attachment: 17342.patch added

enable/disable Lookup button

comment:2 Changed 7 weeks ago by GerdP

I did not yet find out how to scroll the tree so that the first selected tree element is visible. Any hints how to do that?

comment:3 Changed 7 weeks ago by GerdP

Milestone: 19.03
Summary: ValidatorDialog: Lookup button needs improvement[Patch] ValidatorDialog: Lookup button needs improvement

Changed 7 weeks ago by GerdP

Attachment: 17342-v2.patch added

call JTree.scrollPathToVisible()

comment:4 Changed 7 weeks ago by GerdP

Resolution: fixed
Status: newclosed

In 14826/josm:

fix #17342 ValidatorDialog: Lookup button needs improvement

comment:5 Changed 7 weeks ago by GerdP

In 14834/josm:

see #17342: Simplify code and drastically improve performance when selection contains a large number of objects

comment:6 Changed 6 weeks ago by GerdP

In 14854/josm:

see #17342: call updateEnabledState() for Lookup Button also when the data was changed

comment:7 Changed 5 weeks ago by GerdP

In 14887/josm:

see #17342: improve performance: check if selection is empty before searching error list

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.