false positive "Sudden highway type change"

[Klumbumbus]

wiki:Rules/OsmoseValidations

Validate e.g. ​https://www.openstreetmap.org/node/29039893 or ​https://www.openstreetmap.org/node/599192072 which warns about "Sudden highway type change". These are very common tagging situations.

[dmanzer95]

Hello,

The reason that this was flagged was because the residential road and secondary road are coming together at their beginning/endpoints (Same reason for the second example just different highway classifications). I notice that the reason for the split in the secondary road in the first example is because of different sidewalk tags, so this would be a false positive. There will definitely be false positives as there are with OSMOSE.

[Klumbumbus]

Replying to dmanzer95:

There will definitely be false positives

Some false positives are often unavoidable, but imho this rule produces way too much false positives and way more false positives than "right positives" which makes this rule barely useful.

[dmanzer95]

after another look I agree. Working to more closely match OSMOSE results

[Klumbumbus]

I too thought about possible code improvements and I think a proper solution is not possible with the current mapcss implementation in JOSM, but I could be wrong.

[dmanzer95]

I may have a way to narrow down the results but it could get a little messy. I'll test it out and post my findings here. Thanks for bringing this issue up!

[dmanzer95]

Right again, mapcss did not support what was required for this idea.

[abalosc1]

The "Sudden highway type change" check 1090 has been removed