Modify ↓

Opened 5 years ago

Closed 5 years ago

#17249 closed enhancement (fixed)

[Patch] Update religion presets and element styles

Reported by: Claudius Owned by: Klumbumbus
Priority: normal Milestone: 19.03
Component: Internal preset Version:
Keywords: religion denomination worship Cc:

Description (last modified by Klumbumbus)

This patch:

  1. will add two icons to the standard element styling for places of worship for two religions that have ​more than 100 object occurances according to Taginfo already: tenrikyo and confucian
  2. updates the denominations values to cover ​today's top 20 denominations according to taginfo.
  3. replaces the religion value of unitarian with the established and variant documented in the ​OSM wiki about religion unitarian_universalist

The map icons originate from PD wikimedia symbols:
​https://commons.wikimedia.org/wiki/File:Tenrikyo_emblem.svg
​https://commons.wikimedia.org/wiki/File:%E6%9C%A8%E9%90%B8_---_Confucian_wooden-clapper_bell.svg

Attachments (3)

religion_denomination_14731.patch​ (5.7 KB ) - added by Claudius 5 years ago.
tenrikyo.svg​ (14.9 KB ) - added by Claudius 5 years ago.
Updated with white background pagecolor to ensure contrast with light/dark backgrounds. Goes into images/presets/religion
confucian.svg​ (10.0 KB ) - added by Claudius 5 years ago.
Now with white rectangular outline ensure contrast with light/dark backgrounds. Goes into images/presets/religion

Download all attachments as: .zip

Change History (14)

by Claudius, 5 years ago

Attachment: religion_denomination_14731.patch​ added

comment:1 by Klumbumbus, 5 years ago

Component: Core → Internal preset
Milestone: → 19.02

confucian.svg​ is invisible at black background in the mapview. Could you please adjust this? At wiki:/DevelopersGuide/DefaultPresets are some hints regarding new icons.

comment:2 by Don-vip, 5 years ago

Keywords: religion denomination worship added

by Claudius, 5 years ago

Attachment: tenrikyo.svg​ added

Updated with white background pagecolor to ensure contrast with light/dark backgrounds. Goes into images/presets/religion

comment:3 by Claudius, 5 years ago

Thanks for reviewing, Klumbumbus. I've updated both SVGs to ensure they stay visible against black background

comment:4 by Klumbumbus, 5 years ago

It seems the icons are still the same. Did you accidentaly attach the old versions again?

by Claudius, 5 years ago

Attachment: confucian.svg​ added

Now with white rectangular outline ensure contrast with light/dark backgrounds. Goes into images/presets/religion

comment:5 by Don-vip, 5 years ago

Milestone: 19.02 → 19.03

confucian.svg looks empty.

comment:6 by Klumbumbus, 5 years ago

Owner: changed from team to Klumbumbus
Status: new → assigned

comment:7 by Klumbumbus, 5 years ago

Description: modified (diff)

comment:8 by Klumbumbus, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 14867/josm:

fix #17249 - clean up religion and denomination, replace religion=unitarian by religion=unitarian_universalist, warn about religion=catholic, add religion=tenrikyo and religion=confucian, add icons (​https://commons.wikimedia.org/wiki/File:Tenrikyo_emblem.svg and ​https://commons.wikimedia.org/wiki/File:%E6%9C%A8%E9%90%B8_---_Confucian_wooden-clapper_bell.svg, modified, PD and CC0 licensed)

comment:9 by Klumbumbus, 5 years ago

Resolution: fixed
Status: closed → reopened

https://josm.openstreetmap.de/browser/josm/trunk/images/presets/religion/confucian.svg?rev=14867&order=name is displayed only white in trac/firefox but correct in JOSM. todo: check tomorrow if it is still displayed in JOSM correctly after svg cleaner has done its job.

comment:10 by Klumbumbus, 5 years ago

In 14873/josm:

see #17249 - fix confucian icon

comment:11 by Klumbumbus, 5 years ago

Resolution: → fixed
Status: reopened → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.