Dead code in opendata plugin?

[GerdP]

In [o34812] I removed

    public static Collection<OsmPrimitive> selectAllInside(Collection<OsmPrimitive> selected, DataSet dataset) {
        return selectAllInside(selected, dataset, true);
    }

because I found no reference to it. Now I've noticed that org.openstreetmap.josm.plugins.opendata.modules.fr.toulouse.datasets.ToulouseDataSetHandler uses it.
It seems this class is not compiled with ant but in Eclipse it is not excluded.
Should I partially revert the change in [o34812] or should I change the Eclipse project to ignore this source?

[Don-vip]

This is no dead code at all. Modules are compiled separately than the plugin because rarely updated. Can you please revert your change?

[Don-vip]

My Eclipse project is as follows. See where are the build files:

[GerdP]

Replying to Don-vip:

This is no dead code at all. Modules are compiled separately than the plugin because rarely updated. Can you please revert your change?

done with [o34862-34864]

[GerdP]

Replying to Don-vip:

My Eclipse project is as follows. See where are the build files:

Did you update opendata and utilsplugin2 before creating this screenshot?
I still don't understand why I did not see an error when using ant clean dist in opendata. Needs some more diggin..

[GerdP]

OK, I think now I understand. The code is only compiled when you run ant in directory modules. On my machine this also doesn't work:

C:\josm\plugins\opendata\modules>ant clean dist
Buildfile: C:\josm\plugins\opendata\modules\build.xml

clean:

clean:
   [delete] Deleting directory C:\josm\plugins\opendata\modules\fr.datagouvfr\build
   [delete] Deleting: C:\josm\plugins\opendata\dist\fr.datagouvfr.jar

clean:
   [delete] Deleting directory C:\josm\plugins\opendata\modules\fr.paris\build
   [delete] Deleting: C:\josm\plugins\opendata\dist\fr.paris.jar

clean:
   [delete] Deleting directory C:\josm\plugins\opendata\modules\fr.toulouse\build

dist:

init:
    [mkdir] Created dir: C:\josm\plugins\opendata\modules\fr.datagouvfr\build
    [mkdir] Created dir: C:\josm\plugins\opendata\modules\fr.datagouvfr\build\META-INF

compile:
     [echo] compiling sources for ../../dist/fr.datagouvfr.jar ...
    [javac] Compiling 18 source files to C:\josm\plugins\opendata\modules\fr.datagouvfr\build

revision:
   [delete] Deleting: C:\josm\plugins\opendata\modules\fr.datagouvfr\REVISION

copy-resources:
     [copy] Copying 1 file to C:\josm\plugins\opendata\modules\fr.datagouvfr\build

copy-images:
     [copy] Copying 1 file to C:\josm\plugins\opendata\modules\fr.datagouvfr\build\images

dist:
     [echo] creating fr.datagouvfr.jar ...
     [copy] Copying 2 files to C:\josm\plugins\opendata\modules\fr.datagouvfr\build
      [jar] Building jar: C:\josm\plugins\opendata\dist\fr.datagouvfr.jar

init:
    [mkdir] Created dir: C:\josm\plugins\opendata\modules\fr.paris\build
    [mkdir] Created dir: C:\josm\plugins\opendata\modules\fr.paris\build\META-INF

compile:
     [echo] compiling sources for ../../dist/fr.paris.jar ...
    [javac] Compiling 12 source files to C:\josm\plugins\opendata\modules\fr.paris\build

revision:
   [delete] Deleting: C:\josm\plugins\opendata\modules\fr.paris\REVISION

copy-resources:

copy-images:
     [copy] Copying 1 file to C:\josm\plugins\opendata\modules\fr.paris\build\images

dist:
     [echo] creating fr.paris.jar ...
     [copy] Copying 2 files to C:\josm\plugins\opendata\modules\fr.paris\build
      [jar] Building jar: C:\josm\plugins\opendata\dist\fr.paris.jar

init:
    [mkdir] Created dir: C:\josm\plugins\opendata\modules\fr.toulouse\build
    [mkdir] Created dir: C:\josm\plugins\opendata\modules\fr.toulouse\build\META-INF

compile:
     [echo] compiling sources for ../../dist/fr.toulouse.jar ...
    [javac] Compiling 50 source files to C:\josm\plugins\opendata\modules\fr.toulouse\build
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: unclosed character literal
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                        ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: ';' expected
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                          ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: illegal character: '\u201c'
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                           ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: ';' expected
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                            ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: unclosed character literal
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                                ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: not a statement
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                               ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: illegal start of expression
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                                  ^
    [javac] C:\josm\plugins\opendata\modules\fr.toulouse\src\org\openstreetmap\josm\plugins\opendata\modules\fr\toulouse\datasets\services\MarchesPleinVentHandler.java:49: error: ';' expected
    [javac]                     hours += day[1]+" "+value.replace(" ", "").replace('ÔÇô','-').replace('h', ':').replace(":-", ":00-");
    [javac]                                                                                          ^
    [javac] 8 errors

BUILD FAILED
C:\josm\plugins\opendata\modules\build.xml:13: The following error occurred while executing this line:
C:\josm\plugins\opendata\modules\build.xml:8: The following error occurred while executing this line:
C:\josm\plugins\opendata\modules\fr.toulouse\build.xml:41: Compile failed; see the compiler error output for details.

Total time: 1 second

C:\josm\plugins\opendata\modules>ant -version
Apache Ant(TM) version 1.9.7 compiled on April 9 2016

C:\josm\plugins\opendata\modules>javac -version
javac 1.8.0_201

C:\josm\plugins\opendata\modules>

This looks like an utf-8 problem. Maybe in one of my tools?

[GerdP]

Fixed with [o34865]
Open question: Why are the modules not compiled with these commands?

cd plugins\opendata
ant clean dist

[Don-vip]

Because modules are not meant to be updated as often as plugin. Only when needed.