Modify

Opened 11 months ago

Closed 2 months ago

Last modified 3 weeks ago

#17240 closed enhancement (fixed)

Presets: verify that wiki links are no redirect

Reported by: simon04 Owned by: Don-vip
Priority: minor Milestone: 19.10
Component: Unit tests Version:
Keywords: preset redirect http osm-wiki Cc: Don-vip, stoecker

Description (last modified by Klumbumbus)

From ticket:17173#comment:15 Don-vip:

Replying to ticket:17173#comment:14 stoecker:

It should not be default to produce useless redirects for each wiki call.

We should add an integration test to check this.

-> after r15423 Jenkins revealed:

https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/3725/testReport/

github issues see comment:9

Attachments (0)

Change History (20)

comment:1 Changed 11 months ago by Don-vip

Component: CoreUnit tests

comment:2 Changed 2 months ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 2 months ago by Don-vip

Milestone: 19.10

comment:4 Changed 2 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15423/josm:

fix #17240 - Presets: verify that wiki links are no redirect

comment:5 Changed 2 months ago by Klumbumbus

Description: modified (diff)

(typo)

comment:6 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:7 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:8 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:10 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:11 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:12 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:13 Changed 2 months ago by Klumbumbus

Description: modified (diff)

comment:14 Changed 8 weeks ago by Klumbumbus

Description: modified (diff)

comment:15 Changed 8 weeks ago by Klumbumbus

Description: modified (diff)

comment:16 Changed 8 weeks ago by stoecker

Russian is also fixed. One remaining needs an ignore because of permanently changing URL. The other one seems also strange. See GitHub.

comment:17 Changed 8 weeks ago by Klumbumbus

Description: modified (diff)

comment:18 Changed 7 weeks ago by Klumbumbus

Description: modified (diff)

comment:19 Changed 7 weeks ago by Klumbumbus

Last edited 7 weeks ago by Klumbumbus (previous) (diff)

comment:20 Changed 3 weeks ago by Klumbumbus

The test currently returns:

[Found HTTP redirection for http://kolbasa.ru/where/ -> 301 -> https://kolbasa.ru/where/, Found HTTP redirection for https://samson-pharma.ru/pharmacies -> 301 -> http://samson-pharma.ru/pharmacies/]

For me https://samson-pharma.ru/pharmacies redirects to https://samson-pharma.ru/contacts/ instead.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.