correct tag passenger_information_display results in upload warning with non existent blank

[OEPNV_Achim]

What steps will reproduce the problem?

1. enter a tag "passenger_information_display=no" to a public transport platform.
2. Upload changes

What is the expected result?

No error/warning

What happens instead?

warning regarding typo: "value 'no' looks like ' no'.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-12-31 15:09:58 +0100 (Mon, 31 Dec 2018)
Build-Date:2018-12-31 14:24:10
Revision:14620
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14620 de) Windows Server 2012 64-Bit
OS Build number: Windows Server 2012 Standard (9200)
Memory Usage: 878 MB / 1484 MB (277 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 2560x1440
Maximum Screen Size: 2560x1440
Dataset consistency test: No problems found

Plugins:
+ PicLayer (34544)

Tagging presets:
+ E:\AUSTAUSCH\Projekte\EFA OSM\JOSM\VRR stop_position.xml
+ E:\AUSTAUSCH\Projekte\EFA OSM\JOSM\VRR platform.xml

Last errors/warnings:
- W: Unable to request certificate of https://grca.nat.gov.tw
- W: Erweiterungen aktualisieren - org.openstreetmap.josm.plugins.PluginHandler$UpdatePluginsMessagePanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [WMS_BLOCK_v2] Resetting cache

[Klumbumbus]

It seems there is a typo in one of your local preset files:

Tagging presets:
+ E:\AUSTAUSCH\Projekte\EFA OSM\JOSM\VRR stop_position.xml
+ E:\AUSTAUSCH\Projekte\EFA OSM\JOSM\VRR platform.xml

Please check if one has " no" (with that space before the "no") as value set.

[OEPNV_Achim]

in the preset file it looks like this (besides, preset files did not change in the past months, and error is new). There is a blank before "no" in the list of allowed combo values, but it has always been, and also exists for any other combo, and none triggers an error:

<combo key="shelter" text="shelter" values="yes, no" />
<combo key="wheelchair" text="wheelchair" values="yes, no, limited" />
<combo key="bench" text="bench" values="yes, no" />
<combo key="tactile_paving" text="tactile_paving" values="yes, no" />
<combo key="bin" text="bin" values="yes, no" />
<combo key="lit" text="lit" values="yes, no" />
<combo key="passenger_information_display" text="passenger_information_display" values="yes, no" />

[GerdP]

I might change the code that produces the warning to remove leading and trailing blanks from preset values.
On the other hand I did not see those in the defaultpresets.xml.

[Klumbumbus]

Replying to OEPNV_Achim:

(besides, preset files did not change in the past months, and error is new).

Thats because the "x looks liky y" test was enhanced not long ago.

and also exists for any other combo, and none triggers an error:

Thats because the other combos are already in the internal presets with the correct values "no" instead of " no". JOSM automatically removes leading spaces in tags. And the test compares your actual tags with your presets. When you have an object with "passenger_information_display=no" JOSM can only find "passenger_information_display= no" and warns you about a possible typo. However the typo is in the preset not in the actual tag, so the preset must be corrected.

Replying to GerdP:

I might change the code that produces the warning to remove leading and trailing blanks from preset values.

I don't think it makes sense. As a side effect the current behavior even revealed the typos in this preset and can possibly do for other preset files too.

@OEPNV_Achim
Please correct your presets by removing the spaces.

[GerdP]

I would still suggest to implement a check somewhere to detect those wrong preset values. Probably best place for that would be the routine that reads the presets.

[Klumbumbus]

Replying to GerdP:

to implement a check somewhere to detect those wrong preset values

I have no objections.