Opened 7 years ago
Last modified 3 years ago
#17201 new task
fix common typo in progressMonitor beginTask() — at Initial Version
| Reported by: | GerdP | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | progressmonitor | Cc: | gaben |
Description
Due to copy+paste we have quite a lot of sources with this error pattern:
Instead of
progressMonitor.beginTask(tr("Contacting Server...", 10));
it should be
progressMonitor.beginTask(tr("Contacting Server..."), 10);
The effect is that many progress monitors show no progress because the default tick number is 10000.
I found this in the o5m plugin and in some core sources.
Other plugins matching the search pattern "beginTask\(tr.*[0..9]+\)\)" are:
plugins\cadastre-fr\src\org\openstreetmap\josm\plugins\fr\cadastre\download\CadastreServerReader.java plugins\poly\src\poly\DownloadPolyTask.java plugins\imagery-xml-bounds\src\org\openstreetmap\josm\plugins\imageryxmlbounds\io\JosmServerLocationReader.java plugins\pbf\src\org\openstreetmap\josm\plugins\pbf\io\PbfServerReader.java
There may be more where the tick count is not given as a numerical constant.
Note:
See TracTickets
for help on using tickets.


