Modify

Opened 5 weeks ago

Last modified 4 weeks ago

#17201 new task

fix common typo in progressMonitor beginTask()

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

Due to copy+paste we have quite a lot of sources with this error pattern:
Instead of

  progressMonitor.beginTask(tr("Contacting Server...", 10));

it should be

  progressMonitor.beginTask(tr("Contacting Server..."), 10);

The effect is that many progress monitors show no progress because the default tick number is 10000.
I found this in the o5m plugin and in some core sources.

Other plugins matching the search pattern "beginTask\(tr.*[0..9]+\)\)" are:

plugins\cadastre-fr\src\org\openstreetmap\josm\plugins\fr\cadastre\download\CadastreServerReader.java
plugins\poly\src\poly\DownloadPolyTask.java
plugins\imagery-xml-bounds\src\org\openstreetmap\josm\plugins\imageryxmlbounds\io\JosmServerLocationReader.java
plugins\pbf\src\org\openstreetmap\josm\plugins\pbf\io\PbfServerReader.java

There may be more where the tick count is not given as a numerical constant.

Attachments (0)

Change History (4)

comment:1 Changed 5 weeks ago by GerdP

In 14688/josm:

see #17201 improve progressMonitor for internal osm (xml) importer

comment:2 Changed 4 weeks ago by GerdP

o5m plugin see [o34820]
pbf plugin see [o34848:34849]

comment:3 Changed 4 weeks ago by GerdP

In 14716/josm:

see #17201: Improve progress monitor: Let OsmImporter decide what task is following the parser

comment:4 Changed 4 weeks ago by GerdP

Oops, that did not yet work with some plugins. Reverted with r14717.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.