Modify ↓
#17183 closed defect (fixed)
Validator doesn't show errors when panel is not open
Reported by: | GerdP | Owned by: | GerdP |
---|---|---|---|
Priority: | normal | Milestone: | 19.01 |
Component: | Core validator | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Start JOSM
- Crtl+N for new Edit Layer
- If Validator Panel is opened, close it and the data layer and open a new data layer
- Draw a way without adding any tags and run Validator
What is the expected result?
Validator panel should open and show a warning for an untagged way
What happens instead?
Validator panel opens but shows no erros.
Please provide any additional information below. Attach a screenshot if possible.
Executing the validator again shows the expected result. Same problem happens when data is downloaded.
The problem is that ValidatorTreePanel.buildTree()
is called twice, once with the error list and again with an still empty error list retrieved from MainApplication.getLayerManager().getEditLayer().validationErrors
I did not find the best place to fix that.
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2018-12-31 15:09:58 +0100 (Mon, 31 Dec 2018) Build-Date:2018-12-31 14:24:10 Revision:14620 Relative:URL: ^/trunk Identification: JOSM/1.5 (14620 de) Windows 10 64-Bit OS Build number: Windows 10 Home 1803 (17134) Memory Usage: 553 MB / 1820 MB (364 MB allocated, but free) Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: \Display0 1920x1080 Maximum Screen Size: 1920x1080 Plugins: + OpeningHoursEditor (34535) + apache-commons (34506) + buildings_tools (34807) + download_along (34503) + ejml (34389) + geotools (34513) + jaxb (34506) + jts (34524) + o5m (34405) + opendata (34805) + pbf (34576) + poly (34546) + reltoolbox (34788) + reverter (34552) + utilsplugin2 (34793) Last errors/warnings: - W: No configuration settings found. Using hardcoded default values for all pools. - W: Region [TMS_BLOCK_v2] Resetting cache - W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect - W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
Attachments (0)
Change History (3)
comment:1 Changed 2 years ago by
Owner: | changed from team to GerdP |
---|---|
Status: | assigned → new |
comment:2 Changed 2 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 2 years ago by
Milestone: | → 19.01 |
---|
Note: See
TracTickets for help on using
tickets.
In 14666/josm: