Add missing help buttons

[simon04]

Inspired by #15051, I found quite a few dialogs lacking an appropriate help button.

I checked a few dialogs in LibreOffice and GIMP; all of them seem to uniformly contain a Help button. This concept could be applied to JOSM as well: all non-trivial dialogs could get a Help button (e.g., using org.openstreetmap.josm.gui.ExtendedDialog#configureContextsensitiveHelp).

[simon04]

In 14655/josm:

see #17178 - Search presets: add help buttons, add button icons

[simon04]

In 14656/josm:

see #17178 - Search notes: add help button

[simon04]

In 14657/josm:

see #17178 - Save session: add help button

[simon04]

In 14658/josm:

see #17178 - Upload selection: fix help topic, make help button visible

[simon04]

The context-sensitive help is a bit awkward in use for dialogs. For instance:

1. In the "View" menu, I can hover "Advanced info" and press [F1]. The corresponding help page opens.
2. In the "Advanced info" dialog, no help button is present, and pressing [F1] does not open the help page.

The first behaviour originates from setHelpId(ht("/Action/InfoAboutElements")) in org.openstreetmap.josm.actions.InfoAction. The second behaviour is due to configureContextsensitiveHelp("/Action/InfoAboutElements") missing in org.openstreetmap.josm.gui.dialogs.InspectPrimitiveDialog

I find 1. super awkward as I've never seen this in any application (but not distracting); how many users are aware of this? However, 2. is what I would consider the standard user expectation concerning help in applications. Thus, we should org.openstreetmap.josm.gui.ExtendedDialog#configureContextsensitiveHelp where missing. How can we avoid the duplication of help topics for 1. and 2. (e.g., r14658 addressed a discrepancy of help topics between UploadDialog and UploadAction)?

[simon04]

In 14742/josm:

see #17178 - Jump to position: add help button

[simon04]

In 14743/josm:

see #17178 - Rectified Image: add help button

[simon04]

In 14744/josm:

see #17178 - Search menu items: add help button

[simon04]

In 14745/josm:

see #17178 - About: add help button

[simon04]

Skipped:

• PurgeAction (how to add help to ConditionalOptionPaneUtil)
• HistoryInfoAction.HistoryObjectIDDialog (no adequate help topic)

[Klumbumbus]

(follow up in #19669)