Modify ↓
Opened 6 years ago
#17124 new enhancement
Improve conflict solving performance
Reported by: | naoliv | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | |
Keywords: | performance | Cc: |
Description
Suppose we have 1000 conflicts, we select all of them and choose "their version".
It feels that JOSM is slowly resolving them one by one and doing some resource-intensive things each time; it seems that JOSM will call this function a thousand times (for this example):
@Override public void onConflictsRemoved(ConflictCollection conflicts) { Logging.info("1 conflict has been resolved."); refreshView(); }
- Maybe
Logging.info()
should be changed to a more verbose level? (ie, it should not be printed to console when calling JOSM without--trace
,--debug
, etc) - Maybe all the conflicts could be resolved and only then
refreshView()
be called only once, instead calling it every time a conflict is resolved?
JOSM:
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2018-12-17 22:42:01 +0100 (Mon, 17 Dec 2018) Revision:14575 Build-Date:2018-12-18 02:32:19 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (14575 pt_BR) Linux Debian GNU/Linux buster/sid Memory Usage: 312 MB / 2048 MB (74 MB allocated, but free) Java version: 11.0.1+13-Debian-3, Oracle Corporation, OpenJDK 64-Bit Server VM Screen: :0.0 1920x1080 Maximum Screen Size: 1920x1080 Java package: openjdk-11-jre:amd64-11.0.1+13-3 Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21 VM arguments: [-Dawt.useSystemAAFontSettings=gasp] Dataset consistency test: No problems found
Attachments (0)
Note:
See TracTickets
for help on using tickets.