convert boundary=protected_area + protect_class=2 into human readable equivalent boundary=national_park

[mkoniecz]

What steps will reproduce the problem?

1. create closed way
2. add boundary=protected_area
3. add protect_class=2
4. run validator

What is the expected result?

Validator proposes to convert into boundary=national_park with available autofix

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

See ​https://wiki.openstreetmap.org/wiki/Tag:boundary%3Dprotected_area#Nature-protected-area

I discovered this during reviewing ​https://github.com/gravitystorm/openstreetmap-carto/pull/3509#pullrequestreview-182957295

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-12-11 00:24:50 +0100 (Tue, 11 Dec 2018)
Build-Date:2018-12-11 02:32:21
Revision:14551
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14551 en) Linux Ubuntu 16.04.5 LTS
Memory Usage: 482 MB / 869 MB (147 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34535)
+ buildings_tools (34724)
+ continuosDownload (82)
+ imagery_offset_db (34641)
+ measurement (34529)
+ reverter (34552)
+ todo (30306)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[kocio]

I'm not sure if this is good idea, because not all national parks in Poland have the same class and that will drop some part of the information - here are my findings:

Another thing that I was pretty sure of, was that national parks have protection class 2. But out of 23 such parks in Poland only 15 have it, but for example at least two of them has class 5 (according to ​https://pl.wikipedia.org/wiki/Kategorie_ochrony_przyrody_Mi%C4%99dzynarodowej_Unii_Ochrony_Przyrody ). I don't know about other 6, but that's enough to see that there are no hard rules for relations between the local types of protection and IUCN categories.

[ ​https://github.com/gravitystorm/openstreetmap-carto/issues/603#issuecomment-350587768 ]

[mkoniecz]

boundary=national_park with protect_class=5 is simply mistagging (complaining about it may be a good idea for a separate warning), as it is inherently contradictionary

[kocio]

According to Polish Wikipedia, it is not a tagging issue - I think this is an example of local/global classification differences:

W Polsce odpowiadają im parki krajobrazowe, ale także niektóre parki narodowe, jak Wigierski, czy Ojcowski.
In Poland, they are corresponding to landscape parks, but also some national parks, such as Wigierski and Ojcowski.

[ ​https://pl.wikipedia.org/wiki/Kategorie_ochrony_przyrody_Mi%C4%99dzynarodowej_Unii_Ochrony_Przyrody#Kategoria_V ]

[mkoniecz]

In that case it really should be documented at ​https://wiki.openstreetmap.org/wiki/Tag:boundary%3Dprotected_area#Nature-protected-area because it is not really mentioned.

[mkoniecz]

Closing as it was based on a misunderstanding.